kernel_tainted: use linux build tag instead of !windows#847
Open
arunsrini3082 wants to merge 1 commit into
Open
kernel_tainted: use linux build tag instead of !windows#847arunsrini3082 wants to merge 1 commit into
arunsrini3082 wants to merge 1 commit into
Conversation
util.SysReadUintFromFile is defined in internal/util/sysreadfile.go which has a //go:build linux constraint. Using !windows caused build failures on OpenBSD and other non-Linux, non-Windows platforms. /proc/sys/kernel/tainted is Linux-specific, so linux is the correct build tag. Signed-off-by: Arun Srinivasan <arun.srinivasan@flipkart.com> Signed-off-by: Arun S <arun.srinivasan@flipkart.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
util.SysReadUintFromFileis defined ininternal/util/sysreadfile.gowith a
//go:build linuxconstraint. The previous!windowstag causedbuild failures on OpenBSD and other non-Linux, non-Windows platforms
(seen in node_exporter crossbuild CI).
/proc/sys/kernel/taintedis Linux-specific, solinuxis the correctbuild constraint.
Fixes: #844 follow-up