Fix: handle surrogate pairs in FileHistory.store_string#2062
Open
JiajunBernoulli wants to merge 1 commit intoprompt-toolkit:mainfrom
Open
Fix: handle surrogate pairs in FileHistory.store_string#2062JiajunBernoulli wants to merge 1 commit intoprompt-toolkit:mainfrom
JiajunBernoulli wants to merge 1 commit intoprompt-toolkit:mainfrom
Conversation
JiajunBernoulli
force-pushed
the
fix-surrogate-encoding
branch
from
2483efa to
6058198
Compare
FileHistory.store_string crashes with UnicodeEncodeError when the input string contains surrogate pairs (e.g., from Windows clipboard containing emoji). Add errors='replace' to gracefully handle invalid surrogates by replacing them with the Unicode replacement character. Fixes prompt-toolkit#2061
JiajunBernoulli
force-pushed
the
fix-surrogate-encoding
branch
from
6058198 to
2e9062f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
FileHistory.store_stringto gracefully handle surrogate pairs in input strings by usingerrors="replace"when encoding to UTF-8.Problem
FileHistory.store_stringcrashes withUnicodeEncodeErrorwhen the input string contains surrogate pairs (e.g.,\ud83d\udc3afrom Windows clipboard). This commonly occurs on Windows when users paste text containing emoji from certain applications.Solution
Add
errors="replace"to the UTF-8 encoding call, which replaces invalid surrogates with the Unicode replacement character (U+FFFD) instead of raising an exception.Test
Fixes #2061