Commit 23891bc
authored
[codex] fix ci success on main pushes (#81)
## Summary
`test` workflow runs on direct pushes to `main` are failing in the
aggregate `CI Success` job even when this repo's `Unit tests (bats)` and
`Shellcheck` jobs pass.
## Root cause
`CI Success` uses the shared `promptfoo/.github` action that waits for
all checks on the commit. That is the right behavior for pull requests,
but on `push` events to `main` the same commit can also have unrelated
branch-level checks such as `Dependabot` and CodeQL checks. In the
failing run for `9b1c42b`, `Dependabot` completed with `failure`, so `CI
Success` failed this workflow despite the repo-local jobs passing.
## Fix
Keep `CI Success` for `pull_request` events, but skip it on `push`
events. The repo-local `unit` and `lint` jobs still run on pushes to
`main`, and the workflow result now reflects those jobs instead of
unrelated checks.
## Validation
- `make test-unit`
- `shellcheck --severity=error src/crabcode`1 parent 9b1c42b commit 23891bc
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
48 | 50 | | |
49 | 51 | | |
50 | 52 | | |
| |||
0 commit comments