Skip to content

fix: restrict auth token API hosts#1486

Open
mldangelo-oai wants to merge 2 commits into
mainfrom
mdangelo/codex/fix-auth-trusted-api-host-c160
Open

fix: restrict auth token API hosts#1486
mldangelo-oai wants to merge 2 commits into
mainfrom
mdangelo/codex/fix-auth-trusted-api-host-c160

Conversation

@mldangelo-oai
Copy link
Copy Markdown
Contributor

Summary

  • validate bearer-token API hosts before token validation and whoami requests
  • require trusted HTTPS hosts and normalize persisted hosts
  • add pre-network CLI/login guards for HTTP, localhost, lookalikes, credentials, paths, queries, and non-default ports

Validation

  • pytest tests/test_auth_config.py -q: 24 passed
  • ruff format --check modelaudit/auth/config.py modelaudit/auth/client.py tests/test_auth_config.py
  • ruff check modelaudit/auth/config.py modelaudit/auth/client.py tests/test_auth_config.py
  • mypy modelaudit/auth/config.py modelaudit/auth/client.py tests/test_auth_config.py
  • git diff --check

@mldangelo-oai
Copy link
Copy Markdown
Contributor Author

@codex review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 31, 2026

Workflow run and artifacts

Performance Benchmarks

Compared 12 shared benchmarks with a regression threshold of 15%.
Status: 0 regressions, 0 improved, 12 stable, 0 new, 0 missing.
Aggregate shared-benchmark median: 758.35ms -> 764.69ms (+0.8%).

Workload Benchmark Target Size Files Baseline Current Change Status
chunked-upload-stream tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_chunked_upload_stream chunked_stream 278.2 KiB 1 22.36ms 23.65ms +5.8% stable
direct-malicious-upload tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_direct_malicious_upload malicious_reduce 52 B 1 1.44ms 1.50ms +4.3% stable
nested-payload-review tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_nested_payload_review[nested_raw] nested_raw 78 B 1 416.0us 407.7us -2.0% stable
padded-multi-stream-upload tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_padded_multi_stream_upload multi_stream_padded 4.1 KiB 1 1.56ms 1.53ms -2.0% stable
nested-payload-review tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_nested_payload_review[nested_base64] nested_base64 98 B 1 415.9us 410.6us -1.3% stable
clean-training-checkpoint tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_clean_training_checkpoint safe_large 278.2 KiB 1 19.42ms 19.65ms +1.2% stable
mixed-model-repository tests/benchmarks/test_scan_benchmarks.py::test_scan_release_candidate_repository release-candidate 547.3 KiB 32 292.16ms 295.25ms +1.1% stable
duplicate-heavy-registry tests/benchmarks/test_scan_benchmarks.py::test_scan_duplicate_registry_snapshot registry-snapshot 915.2 KiB 13 215.29ms 217.40ms +1.0% stable
nested-payload-review tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_nested_payload_review[nested_hex] nested_hex 130 B 1 425.2us 428.2us +0.7% stable
suspicious-pickle-intake tests/benchmarks/test_scan_benchmarks.py::test_scan_suspicious_pickle_intake suspicious-intake 183.8 KiB 4 99.46ms 98.96ms -0.5% stable
warm-cache-rescan tests/benchmarks/test_scan_benchmarks.py::test_scan_warm_cached_repository_rescan release-candidate 547.3 KiB 32 64.91ms 65.03ms +0.2% stable
single-checkpoint-preflight tests/benchmarks/test_scan_benchmarks.py::test_scan_single_checkpoint_before_load single_checkpoint.pkl 183.0 KiB 1 40.49ms 40.48ms -0.0% stable

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13f1888a06

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modelaudit/auth/config.py Outdated
@mldangelo-oai mldangelo-oai marked this pull request as ready for review May 31, 2026 13:19
Copy link
Copy Markdown
Contributor

@ianw-oai ianw-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed; this looks acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants