test: cover Skops getattribute member scanning#1496
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…ops-python-member-getattribute-c155
|
QA summary for current head 02e21ca:\n\n- Reviewed the diff against current origin/main; only CHANGELOG.md and tests/scanners/test_skops_scanner.py are in the PR diff.\n- Verified the malicious Skops fixture catches the getattribute-mediated os.system false-negative path.\n- Verified the benign getattribute fixture stays quiet to guard false positives.\n- Local validation passed: new two-test slice (2 passed), full Skops scanner tests (59 passed), shared ZIP namespace/getattribute FP/FN slice (121 passed), and full Skops+ZIP bundle (511 passed, 1 warning).\n- Current-head GitHub checks are green, including CI Success, Type Check, Lint and Format, Python 3.10, Python 3.13, Windows 3.11, CodeQL, docs formatting, build/package, and vendored proto checks.\n\nI could not submit an approving review because GitHub treats this account as the PR author; auto-merge is enabled and waiting on the required independent review gate. |
Summary
Validation