chore: post-merge cleanup of #941 review nits#943
Merged
Conversation
- Extract isDirectory helper into src/utils/fs.ts; remove duplicated copies in src/main.ts and src/utils/config.ts. - Drop unnecessary String(...) cast around compareBase in main.ts. - Normalize dist artifact paths inside listFiles() in the rebuild workflow, eliminating two downstream .replace() calls. - Refresh stale AGENTS.md note (action already runs on node20). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors the isDirectory helper into a shared utility module to eliminate duplication between src/main.ts and src/utils/config.ts. Also includes minor cleanup in src/main.ts, an AGENTS.md note update, and path normalization simplification in a workflow file.
Changes:
- Extracted
isDirectoryinto newsrc/utils/fs.tsand imported it from bothmain.tsandconfig.ts. - Simplified
compareBaseassignment inmain.ts(removed redundantString()wrapper). - Normalized dist file paths at listing time in the dependabot workflow, removing duplicated
replacecalls.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/fs.ts | New shared utility module exporting isDirectory. |
| src/utils/config.ts | Removed local isDirectory and imported from new module. |
| src/main.ts | Removed local isDirectory, imported shared one; simplified compareBase. |
| dist/index.js | Regenerated bundle reflecting the source changes. |
| AGENTS.md | Updated note to reflect Node 20 runtime. |
| .github/workflows/dependabot-post-update.yml | Normalize dist paths once at listing instead of at each use. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #941 with the remaining low-priority items from the review that didn't make it into the merged commit.
isDirectoryhelper intosrc/utils/fs.ts; remove duplicated copies insrc/main.tsandsrc/utils/config.ts.String(...)cast aroundcompareBaseinsrc/main.ts(GitHub Action inputs are already strings).listFiles()in the rebuild workflow, eliminating two downstream.replace()calls on the result.node20.No behavior changes; pure cleanup.
Test plan
🤖 Generated with Claude Code