fix: handle None stdout/stderr in smoke tests

mldangelo · mldangelo · commit 13c1f1d9cfe5 · 2026-01-06T07:27:45.000-08:00
Add safety checks for None values from subprocess.run() output,
which can occur on Windows in certain error conditions.
diff --git a/tests/smoke/test_smoke.py b/tests/smoke/test_smoke.py
@@ -61,8 +61,8 @@ def run_promptfoo(
         timeout=120,  # Increased timeout for npx fallback (first npx call downloads promptfoo)
     )
 
-    stdout = result.stdout
-    stderr = result.stderr
+    stdout = result.stdout or ""
+    stderr = result.stderr or ""
     exit_code = result.returncode
 
     if not expect_error and exit_code != 0:

Original file line number	Diff line number	Diff line change
`@@ -61,8 +61,8 @@ def run_promptfoo(`
`61`	`61`	`timeout=120, # Increased timeout for npx fallback (first npx call downloads promptfoo)`
`62`	`62`	`)`
`63`	`63`
`64`		`- stdout = result.stdout`
`65`		`- stderr = result.stderr`
	`64`	`+ stdout = result.stdout or ""`
	`65`	`+ stderr = result.stderr or ""`
`66`	`66`	`exit_code = result.returncode`
`67`	`67`
`68`	`68`	`if not expect_error and exit_code != 0:`