fix: add type annotations and clean up CI workarounds

- Add proper type annotation for cmd variable (Union[str, list[str]])
- Run ruff format to fix formatting issues
- Remove retry logic from CI workflow (no longer needed)
- Remove npm cache cleanup (no longer needed)

The core Windows fix (shell=True for .cmd execution) resolves the root
cause, making the retry and cache cleanup workarounds unnecessary.

Co-Authored-By: Michael D'Angelo <michael@promptfoo.dev>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: claude

.github/workflows/test.yml

@@ -86,18 +86,8 @@ jobs:
       - name: Install package
         run: uv sync
 
-      - name: Clear npm cache on Windows
-        if: runner.os == 'Windows'
-        run: npm cache clean --force
-        continue-on-error: true
-
       - name: Test CLI can be invoked
-        uses: nick-fields/retry@v3
-        with:
-          timeout_minutes: 3
-          max_attempts: 3
-          retry_on: error
-          command: uv run promptfoo --version
+        run: uv run promptfoo --version
 
       - name: Test Node.js detection
         run: uv run python -c "from promptfoo.cli import check_node_installed, check_npx_installed; assert check_node_installed(); assert check_npx_installed()"

src/promptfoo/cli.py

@@ -10,7 +10,7 @@
 import shutil
 import subprocess
 import sys
-from typing import NoReturn
+from typing import NoReturn, Union
 
 
 def check_node_installed() -> bool:
@@ -58,10 +58,12 @@ def main() -> NoReturn:
     is_windows = platform.system() == "Windows"
 
     # On Windows, we need special handling for .cmd files
+    cmd: Union[str, list[str]]
     if is_windows:
         # On Windows, build command as string for shell=True
         # This properly handles npx.cmd batch file execution
         import shlex
+
         args = ["npx", "--yes", "promptfoo@latest"] + sys.argv[1:]
         cmd = " ".join(shlex.quote(arg) for arg in args)
         use_shell = True