fix: resolve environment test quality findings

Author: mldangelo-oai

tests/test_environment.py

@@ -55,23 +55,15 @@ def test_detect_derivative_distro_pop_os(self, tmp_path: Path) -> None:
         os_release = tmp_path / "os-release"
         os_release.write_text('ID=pop\nVERSION_ID="22.04"\nID_LIKE="ubuntu debian"')
 
-        os_release_data = 'ID=pop\nVERSION_ID="22.04"\nID_LIKE="ubuntu debian"'
+        missing_path = mock.Mock()
+        missing_path.exists.return_value = False
 
-        with (
-            mock.patch("promptfoo.environment.Path") as mock_path_class,
-            mock.patch("builtins.open", mock.mock_open(read_data=os_release_data)),
-        ):
+        with mock.patch("promptfoo.environment.Path") as mock_path_class:
 
-            def path_side_effect(path_str: str) -> mock.Mock:
-                mock_path_obj = mock.Mock()
+            def path_side_effect(path_str: str) -> object:
                 if path_str == "/etc/os-release":
-                    mock_path_obj.exists.return_value = True
-                    mock_path_obj.__truediv__ = lambda self, other: os_release
-                    # Make the mock path object work with open()
                     return os_release
-                else:
-                    mock_path_obj.exists.return_value = False
-                return mock_path_obj
+                return missing_path
 
             mock_path_class.side_effect = path_side_effect
 
@@ -114,15 +106,6 @@ def test_detect_derivative_distro_linux_mint(self, tmp_path: Path) -> None:
     def test_usr_lib_os_release_fallback(self, tmp_path: Path) -> None:
         """Detect distro from /usr/lib/os-release if /etc/os-release missing."""
         with mock.patch("promptfoo.environment.Path") as mock_path_class:
-
-            def path_exists_side_effect(path_obj: mock.Mock) -> bool:
-                # /etc/os-release doesn't exist, /usr/lib/os-release does
-                if "/etc/os-release" in str(path_obj):
-                    return False
-                elif "/usr/lib/os-release" in str(path_obj):
-                    return True
-                return False
-
             # Create mock Path objects
             etc_path = mock.Mock()
             etc_path.exists.return_value = False