[codex] fix: clarify best-effort environment probe failures#38
Merged
mldangelo-oai merged 1 commit intomainfrom Apr 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub code scanning flagged several empty
except OSError: passblocks insrc/promptfoo/environment.py.Those handlers were intentional best-effort fallbacks around optional
/procand/sysprobe files, so the findings are effectively false positives from a runtime behavior perspective. The downside was that the code made this intent implicit, which left the scanner and human readers with no explanation for why those exceptions were ignored.Fix
This change centralizes optional probe-file reads in
_read_probe_file(), which returnsNonewhen a probe file is missing or unreadable and documents why that fallback is safe for environment detection.The Linux distro, cloud provider, container, and WSL detectors now call that helper instead of repeating inline
try/except OSErrorblocks.Validation
Ran:
uv run ruff check src/ tests/test_environment.pyuv run ruff format --check src/ tests/test_environment.pyuv run mypy src/promptfoo/uv run pyright src/promptfoo/uv run pytest tests/test_environment.py