Register payment methods via action hook#254
Merged
remcotolsma merged 1 commit intoApr 15, 2026
Merged
Conversation
Replace the large, hardcoded payment method registration block in Plugin::register_payment_methods() with a do_action('pronamic_pay_register_payment_methods', $this->payment_methods) call. Remove the ImageService import and delegation of default method registrations so integrations and external packages can register payment methods in plugin space. Update CHANGELOG.md to document the new action, the changed registration flow, the move of Pronamic default methods to the pronamic-pay-default-payment-methods package, and a fix for Billink and Focum image assignment.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the payment method registration process by removing a large block of hardcoded payment method definitions from the core Plugin class. These registrations have been moved to an external package, and a new WordPress action, pronamic_pay_register_payment_methods, has been introduced to allow for dynamic registration. The CHANGELOG.md has been updated to reflect these changes and a fix for image assignments. I have no feedback to provide.
There was a problem hiding this comment.
Pull request overview
This PR refactors how payment methods are registered by removing the large hardcoded registration block in Plugin::register_payment_methods() and replacing it with a new pronamic_pay_register_payment_methods action hook, aiming to let integrations/external packages register methods in “plugin space”.
Changes:
- Replaced hardcoded default payment method registrations with
do_action( 'pronamic_pay_register_payment_methods', $this->payment_methods ). - Removed the
ImageServiceimport and all in-core logo assignment for default payment methods. - Updated
CHANGELOG.mdto document the new hook and the intended move of default method registrations to an external package.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Plugin.php |
Replaces in-core payment method registrations with an action hook invocation. |
CHANGELOG.md |
Documents the new hook and the changed registration flow/move to an external package. |
Comment on lines
+15
to
+20
| - Updated payment method registration flow so payment methods are registered via the `pronamic_pay_register_payment_methods` action. | ||
| - Moved Pronamic default payment method registration out of core and into the [`pronamic/pronamic-pay-default-payment-methods`](https://github.com/pronamic/pronamic-pay-default-payment-methods) package. | ||
|
|
||
| ### Fixed | ||
|
|
||
| - Fixed image assignment for Billink and Focum in default payment method registration (now in [`pronamic/pronamic-pay-default-payment-methods`](https://github.com/pronamic/pronamic-pay-default-payment-methods)). |
There was a problem hiding this comment.
The changelog states that default payment method registration was moved to pronamic/pronamic-pay-default-payment-methods, but this PR doesn’t add that package as a dependency or show any bootstrap code that attaches a callback to pronamic_pay_register_payment_methods. Either update the changelog to clarify that core no longer ships defaults unless that package (or another plugin) is installed, or include the necessary dependency/bootstrapping as part of this change so the statement is accurate for this release.
Comment on lines
+628
to
632
| * @param PaymentMethodsCollection $payment_methods Payment methods collection. | ||
| */ | ||
| /* translators: %s: provider */ | ||
| $bnpl_disclaimer_template = \__( 'You must be at least 18+ to use this service. If you pay on time, you will avoid additional costs and ensure that you can use %s services again in the future. By continuing, you accept the Terms and Conditions and confirm that you have read the Privacy Statement and Cookie Statement.', 'pronamic_ideal' ); | ||
|
|
||
| // AfterPay.nl. | ||
| $payment_method_afterpay_nl = new PaymentMethod( PaymentMethods::AFTERPAY_NL ); | ||
|
|
||
| $payment_method_afterpay_nl->descriptions = [ | ||
| /** | ||
| * AfterPay method description. | ||
| * | ||
| * @link https://www.afterpay.nl/en/customers/where-can-i-pay-with-afterpay | ||
| */ | ||
| 'default' => \__( 'AfterPay is one of the largest and most popular post-payment system in the Benelux. Millions of Dutch and Belgians use AfterPay to pay for products.', 'pronamic_ideal' ), | ||
| ]; | ||
|
|
||
| $payment_method_afterpay_nl->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/afterpay-nl/method-afterpay-nl-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_afterpay_nl ); | ||
|
|
||
| // AfterPay.com. | ||
| $payment_method_afterpay_com = new PaymentMethod( PaymentMethods::AFTERPAY_COM ); | ||
|
|
||
| $payment_method_afterpay_com->descriptions = [ | ||
| /** | ||
| * Afterpay method description. | ||
| * | ||
| * @link https://en.wikipedia.org/wiki/Afterpay | ||
| * @link https://docs.adyen.com/payment-methods/afterpaytouch | ||
| */ | ||
| 'default' => \__( 'Afterpay is a popular buy now, pay later service in Australia, New Zealand, the United States, and Canada.', 'pronamic_ideal' ), | ||
| ]; | ||
|
|
||
| $payment_method_afterpay_com->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/afterpay-com/method-afterpay-com-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_afterpay_com ); | ||
|
|
||
| // Alipay. | ||
| $payment_method_alipay = new PaymentMethod( PaymentMethods::ALIPAY ); | ||
|
|
||
| $payment_method_alipay->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/alipay/method-alipay-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_alipay ); | ||
|
|
||
| // Alma. | ||
| $payment_method_alma = new PaymentMethod( PaymentMethods::ALMA ); | ||
|
|
||
| $this->payment_methods->add( $payment_method_alma ); | ||
|
|
||
| // American Express. | ||
| $payment_method_american_express = new PaymentMethod( PaymentMethods::AMERICAN_EXPRESS ); | ||
|
|
||
| $payment_method_american_express->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/american-express/method-american-express-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_american_express ); | ||
|
|
||
| // Apple Pay. | ||
| $payment_method_apple_pay = new PaymentMethod( PaymentMethods::APPLE_PAY ); | ||
|
|
||
| $payment_method_apple_pay->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/apple-pay/method-apple-pay-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_apple_pay ); | ||
|
|
||
| // BANCOMAT Pay. | ||
| $payment_method_bancomat_pay = new PaymentMethod( PaymentMethods::BANCOMAT_PAY ); | ||
|
|
||
| $this->payment_methods->add( $payment_method_bancomat_pay ); | ||
|
|
||
| // Bancontact. | ||
| $payment_method_bancontact = new PaymentMethod( PaymentMethods::BANCONTACT ); | ||
|
|
||
| $payment_method_bancontact->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/bancontact/method-bancontact-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_bancontact ); | ||
|
|
||
| // Bank Transfer. | ||
| $payment_method_bank_transfer = new PaymentMethod( PaymentMethods::BANK_TRANSFER ); | ||
|
|
||
| $payment_method_bank_transfer->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/bank-transfer/method-bank-transfer-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_bank_transfer ); | ||
|
|
||
| // Belfius Direct Net. | ||
| $payment_method_belfius = new PaymentMethod( PaymentMethods::BELFIUS ); | ||
|
|
||
| $payment_method_belfius->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/belfius/method-belfius-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_belfius ); | ||
|
|
||
| // Billie. | ||
| $payment_method_billie = new PaymentMethod( PaymentMethods::BILLIE ); | ||
|
|
||
| $payment_method_billie->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/billie/method-billie-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_billie ); | ||
|
|
||
| // Billink. | ||
| $payment_method_billink = new PaymentMethod( PaymentMethods::BILLINK ); | ||
|
|
||
| $payment_method_billie->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/billink/method-billink-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_billink ); | ||
|
|
||
| // Bitcoin. | ||
| $payment_method_bitcoin = new PaymentMethod( PaymentMethods::BITCOIN ); | ||
|
|
||
| $payment_method_bitcoin->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/bitcoin/method-bitcoin-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_bitcoin ); | ||
|
|
||
| // BLIK. | ||
| $payment_method_blik = new PaymentMethod( PaymentMethods::BLIK ); | ||
|
|
||
| $payment_method_blik->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/blik/method-blik-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_blik ); | ||
|
|
||
| // Bunq. | ||
| $payment_method_bunq = new PaymentMethod( PaymentMethods::BUNQ ); | ||
|
|
||
| $payment_method_bunq->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/bunq/method-bunq-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_bunq ); | ||
|
|
||
| // In3. | ||
| $payment_method_in3 = new PaymentMethod( PaymentMethods::IN3 ); | ||
|
|
||
| $payment_method_in3->descriptions = [ | ||
| 'customer' => \sprintf( $bnpl_disclaimer_template, $payment_method_in3->name ), | ||
| ]; | ||
|
|
||
| $payment_method_in3->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/in3/method-in3-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_in3 ); | ||
|
|
||
| // Capayable. | ||
| $payment_method_capayable = new PaymentMethod( PaymentMethods::CAPAYABLE ); | ||
|
|
||
| $payment_method_capayable->images = []; | ||
|
|
||
| $this->payment_methods->add( $payment_method_capayable ); | ||
|
|
||
| // Card. | ||
| $payment_method_card = new PaymentMethod( PaymentMethods::CARD ); | ||
|
|
||
| $payment_method_card->descriptions = [ | ||
| 'default' => \__( 'The most popular payment method in the world. Offers customers a safe and trusted way to pay online. Customers can pay for their order quickly and easily with their card, without having to worry about their security. It is possible to charge a payment surcharge for card costs.', 'pronamic_ideal' ), | ||
| ]; | ||
|
|
||
| $payment_method_card->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/credit-card/method-credit-card-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_card ); | ||
|
|
||
| // Credit card. | ||
| $payment_method_credit_card = new PaymentMethod( PaymentMethods::CREDIT_CARD ); | ||
|
|
||
| $payment_method_credit_card->descriptions = [ | ||
| 'default' => \__( 'The most popular payment method in the world. Offers customers a safe and trusted way to pay online. Customers can pay for their order quickly and easily with their credit card, without having to worry about their security. It is possible to charge a payment surcharge for credit card costs.', 'pronamic_ideal' ), | ||
| ]; | ||
|
|
||
| $payment_method_credit_card->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/credit-card/method-credit-card-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_credit_card ); | ||
|
|
||
| // Payment method iDEAL | Wero. | ||
| $payment_method_ideal = new PaymentMethod( PaymentMethods::IDEAL ); | ||
|
|
||
| $payment_method_ideal->descriptions = [ | ||
| 'customer' => \__( 'With iDEAL you can easily pay online in the secure environment of your own bank.', 'pronamic_ideal' ), | ||
| ]; | ||
|
|
||
| $payment_method_ideal->name = \__( 'iDEAL | Wero', 'pronamic_ideal' ); | ||
|
|
||
| $payment_method_ideal->images = [ | ||
| '640x360' => $image_service->get_path( 'other/ideal-wero/ideal-wero-640x360.svg' ), | ||
| 'woocommerce' => $image_service->get_path( 'other/ideal-wero/method-ideal-wero-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_ideal ); | ||
|
|
||
| // Direct debit. | ||
| $payment_method_direct_debit = new PaymentMethod( PaymentMethods::DIRECT_DEBIT ); | ||
|
|
||
| $payment_method_direct_debit->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/direct-debit/method-direct-debit-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_direct_debit ); | ||
|
|
||
| /* translators: %s: payment method */ | ||
| $description_template = \__( 'By using this payment method you authorize us via %s to debit payments from your bank account.', 'pronamic_ideal' ); | ||
|
|
||
| // Direct debit (mandate via Bancontact). | ||
| $payment_method_direct_debit_bancontact = new PaymentMethod( PaymentMethods::DIRECT_DEBIT_BANCONTACT ); | ||
|
|
||
| $payment_method_direct_debit_bancontact->descriptions = [ | ||
| 'customer' => \sprintf( $description_template, $payment_method_direct_debit_bancontact->name ), | ||
| ]; | ||
|
|
||
| $payment_method_direct_debit_bancontact->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/direct-debit-bancontact/method-direct-debit-bancontact-wc-107x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_direct_debit_bancontact ); | ||
|
|
||
| // Direct debit (mandate via iDEAL | Wero). | ||
| $payment_method_direct_debit_ideal = new PaymentMethod( PaymentMethods::DIRECT_DEBIT_IDEAL ); | ||
|
|
||
| $payment_method_direct_debit_ideal->descriptions = [ | ||
| 'customer' => \sprintf( $description_template, $payment_method_direct_debit_ideal->name ), | ||
| ]; | ||
|
|
||
| $payment_method_direct_debit_ideal->images = $payment_method_ideal->images; | ||
|
|
||
| $this->payment_methods->add( $payment_method_direct_debit_ideal ); | ||
|
|
||
| // Direct debit (mandate via SOFORT). | ||
| $payment_method_direct_debit_sofort = new PaymentMethod( PaymentMethods::DIRECT_DEBIT_SOFORT ); | ||
|
|
||
| $payment_method_direct_debit_sofort->descriptions = [ | ||
| 'customer' => \sprintf( $description_template, $payment_method_direct_debit_sofort->name ), | ||
| ]; | ||
|
|
||
| $payment_method_direct_debit_sofort->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/direct-debit-sofort/method-direct-debit-sofort-wc-107x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_direct_debit_sofort ); | ||
|
|
||
| // EPS. | ||
| $payment_method_eps = new PaymentMethod( PaymentMethods::EPS ); | ||
|
|
||
| $payment_method_eps->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/eps/method-eps-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_eps ); | ||
|
|
||
| // Focum. | ||
| $payment_method_focum = new PaymentMethod( PaymentMethods::FOCUM ); | ||
|
|
||
| $payment_method_eps->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/focum/method-focum-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_focum ); | ||
|
|
||
| // Gift Card. | ||
| $payment_method_gift_card = new PaymentMethod( PaymentMethods::GIFT_CARD ); | ||
|
|
||
| $this->payment_methods->add( $payment_method_gift_card ); | ||
|
|
||
| // IDEAL QR. | ||
| $payment_method_ideal_qr = new PaymentMethod( PaymentMethods::IDEALQR ); | ||
|
|
||
| $payment_method_ideal_qr->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/ideal-qr/method-ideal-qr-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_ideal_qr ); | ||
|
|
||
| // Giropay. | ||
| $payment_method_giropay = new PaymentMethod( PaymentMethods::GIROPAY ); | ||
|
|
||
| $payment_method_giropay->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/giropay/method-giropay-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_giropay ); | ||
|
|
||
| // Google Pay. | ||
| $payment_method_google_pay = new PaymentMethod( PaymentMethods::GOOGLE_PAY ); | ||
|
|
||
| $payment_method_google_pay->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/google-pay/method-google-pay-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_google_pay ); | ||
|
|
||
| // KBC/CBC Payment Button. | ||
| $payment_method_kbc = new PaymentMethod( PaymentMethods::KBC ); | ||
|
|
||
| $payment_method_kbc->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/kbc/method-kbc-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_kbc ); | ||
|
|
||
| // Klarna. | ||
| $payment_method_klarna = new PaymentMethod( PaymentMethods::KLARNA ); | ||
|
|
||
| $payment_method_klarna->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/klarna/method-klarna-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_klarna ); | ||
|
|
||
| // Klarna Pay Later. | ||
| $payment_method_klarna_pay_later = new PaymentMethod( PaymentMethods::KLARNA_PAY_LATER ); | ||
|
|
||
| $payment_method_klarna_pay_later->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/klarna-pay-later/method-klarna-pay-later-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $payment_method_klarna_pay_later->descriptions = [ | ||
| 'customer' => \sprintf( $bnpl_disclaimer_template, $payment_method_klarna_pay_later->name ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_klarna_pay_later ); | ||
|
|
||
| // Klarna Pay Now. | ||
| $payment_method_klarna_pay_now = new PaymentMethod( PaymentMethods::KLARNA_PAY_NOW ); | ||
|
|
||
| $payment_method_klarna_pay_now->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/klarna-pay-now/method-klarna-pay-now-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_klarna_pay_now ); | ||
|
|
||
| // Klarna Pay Over Time. | ||
| $payment_method_klarna_pay_over_time = new PaymentMethod( PaymentMethods::KLARNA_PAY_OVER_TIME ); | ||
|
|
||
| $payment_method_klarna_pay_over_time->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/klarna-pay-over-time/method-klarna-pay-over-time-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_klarna_pay_over_time ); | ||
|
|
||
| // Maestro. | ||
| $payment_method_maestro = new PaymentMethod( PaymentMethods::MAESTRO ); | ||
|
|
||
| $payment_method_maestro->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/maestro/method-maestro-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_maestro ); | ||
|
|
||
| // Mastercard. | ||
| $payment_method_mastercard = new PaymentMethod( PaymentMethods::MASTERCARD ); | ||
|
|
||
| $payment_method_mastercard->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/mastercard/method-mastercard-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_mastercard ); | ||
|
|
||
| // MB WAY. | ||
| $payment_method_mb_way = new PaymentMethod( PaymentMethods::MB_WAY ); | ||
|
|
||
| $payment_method_mb_way->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/mb-way/method-mb-way-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_mb_way ); | ||
|
|
||
| // Multibanco. | ||
| $payment_method_multibanco = new PaymentMethod( PaymentMethods::MULTIBANCO ); | ||
|
|
||
| $this->payment_methods->add( $payment_method_multibanco ); | ||
|
|
||
| // MyBank. | ||
| $payment_method_mybank = new PaymentMethod( PaymentMethods::MYBANK ); | ||
|
|
||
| $this->payment_methods->add( $payment_method_mybank ); | ||
|
|
||
| // Pay by Bank. | ||
| $payment_method_pay_by_bank = new PaymentMethod( PaymentMethods::PAY_BY_BANK ); | ||
|
|
||
| $this->payment_methods->add( $payment_method_pay_by_bank ); | ||
|
|
||
| // Payconiq. | ||
| $payment_method_payconiq = new PaymentMethod( PaymentMethods::PAYCONIQ ); | ||
|
|
||
| $payment_method_payconiq->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/payconiq/method-payconiq-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_payconiq ); | ||
|
|
||
| // PayPal. | ||
| $payment_method_paypal = new PaymentMethod( PaymentMethods::PAYPAL ); | ||
|
|
||
| $payment_method_paypal->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/paypal/method-paypal-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_paypal ); | ||
|
|
||
| // Paysafecard. | ||
| $payment_method_paysafecard = new PaymentMethod( PaymentMethods::PAYSAFECARD ); | ||
|
|
||
| $this->payment_methods->add( $payment_method_paysafecard ); | ||
|
|
||
| // Postepay. | ||
| $payment_method_postepay = new PaymentMethod( PaymentMethods::POSTEPAY ); | ||
|
|
||
| $this->payment_methods->add( $payment_method_postepay ); | ||
|
|
||
| // Przelewy24. | ||
| $payment_method_przelewy24 = new PaymentMethod( PaymentMethods::PRZELEWY24 ); | ||
|
|
||
| $payment_method_przelewy24->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/przelewy24/method-przelewy24-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_przelewy24 ); | ||
|
|
||
| // Riverty. | ||
| $payment_method_riverty = new PaymentMethod( PaymentMethods::RIVERTY ); | ||
|
|
||
| $payment_method_riverty->descriptions = [ | ||
| 'default' => \__( 'Riverty (formerly AfterPay) is a payment service that allows customers to pay after receiving the product.', 'pronamic_ideal' ), | ||
| 'customer' => \sprintf( $bnpl_disclaimer_template, $payment_method_riverty->name ), | ||
| ]; | ||
|
|
||
| $payment_method_riverty->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/riverty/method-riverty-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_riverty ); | ||
|
|
||
| // Santander. | ||
| $payment_method_santander = new PaymentMethod( PaymentMethods::SANTANDER ); | ||
|
|
||
| $payment_method_santander->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/santander/method-santander-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_santander ); | ||
|
|
||
| // Satispay. | ||
| $payment_method_satispay = new PaymentMethod( PaymentMethods::SATISPAY ); | ||
|
|
||
| $this->payment_methods->add( $payment_method_satispay ); | ||
|
|
||
| // SOFORT Banking. | ||
| $payment_method_sofort = new PaymentMethod( PaymentMethods::SOFORT ); | ||
|
|
||
| $payment_method_sofort->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/sofort/method-sofort-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_sofort ); | ||
|
|
||
| // SprayPay. | ||
| $payment_method_spraypay = new PaymentMethod( PaymentMethods::SPRAYPAY ); | ||
|
|
||
| $payment_method_spraypay->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/spraypay/method-spraypay-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_spraypay ); | ||
|
|
||
| // Swish. | ||
| $payment_method_swish = new PaymentMethod( PaymentMethods::SWISH ); | ||
|
|
||
| $payment_method_swish->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/swish/method-swish-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_swish ); | ||
|
|
||
| // Trustly. | ||
| $payment_method_trustly = new PaymentMethod( PaymentMethods::TRUSTLY ); | ||
|
|
||
| $this->payment_methods->add( $payment_method_trustly ); | ||
|
|
||
| // TWINT. | ||
| $payment_method_twint = new PaymentMethod( PaymentMethods::TWINT ); | ||
|
|
||
| $payment_method_twint->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/twint/method-twint-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_twint ); | ||
|
|
||
| // V PAY. | ||
| $payment_method_v_pay = new PaymentMethod( PaymentMethods::V_PAY ); | ||
|
|
||
| $payment_method_v_pay->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/v-pay/method-v-pay-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_v_pay ); | ||
|
|
||
| // Vipps. | ||
| $payment_method_vipps = new PaymentMethod( PaymentMethods::VIPPS ); | ||
|
|
||
| $payment_method_vipps->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/vipps/method-vipps-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_vipps ); | ||
|
|
||
| // Visa. | ||
| $payment_method_visa = new PaymentMethod( PaymentMethods::VISA ); | ||
|
|
||
| $payment_method_visa->images = [ | ||
| 'woocommerce' => $image_service->get_path( 'methods/visa/method-visa-wc-51x32.svg' ), | ||
| ]; | ||
|
|
||
| $this->payment_methods->add( $payment_method_visa ); | ||
|
|
||
| // Vouchers. | ||
| $payment_method_vouchers = new PaymentMethod( PaymentMethods::VOUCHERS ); | ||
|
|
||
| $this->payment_methods->add( $payment_method_vouchers ); | ||
| do_action( 'pronamic_pay_register_payment_methods', $this->payment_methods ); | ||
|
|
||
| PaymentMethods::maybe_update_active_payment_methods(); |
There was a problem hiding this comment.
register_payment_methods() now only fires pronamic_pay_register_payment_methods, but there are no listeners for this hook in this repository (and composer.json doesn’t require the mentioned default-payment-methods package). As a result, the plugin’s PaymentMethodsCollection will remain empty, which breaks places that iterate $this->plugin->get_payment_methods() (e.g. payment method settings registration) and removes method metadata (images/descriptions) from core. Consider registering a default callback in core (or explicitly requiring/bootstrapping the default-payment-methods package here) and/or providing a backwards-compatible fallback when no methods are registered.
remcotolsma
deleted the
51-request-for-adding-missing-filters-in-paymentmethodsphp
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the large, hardcoded payment method registration block in Plugin::register_payment_methods() with a do_action('pronamic_pay_register_payment_methods', $this->payment_methods) call. Remove the ImageService import and delegation of default method registrations so integrations and external packages can register payment methods in plugin space. Update CHANGELOG.md to document the new action, the changed registration flow, the move of Pronamic default methods to the pronamic-pay-default-payment-methods package, and a fix for Billink and Focum image assignment.