Limit use of "Send Notifications Delay" to existing users, preparing for its future removal in favour of notification events.

[rvdsteege]

Fix #7.

[gemini-code-assist]

Summary of Changes

Hello @rvdsteege, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request begins the deprecation process for the 'Send Notifications Delay' feature within the admin settings. It refactors the display logic to only present this option to existing users who have previously configured it, while simultaneously guiding new users towards the recommended 'notification events' system. This change prepares the codebase for the eventual removal of the older delay mechanism, aiming to streamline notification management and encourage adoption of the new event-based approach.

Highlights

• Deprecation of 'Send Notifications Delay': The 'Send Notifications Delay' option in the admin settings is now conditionally displayed, marking a step towards its future removal.
• Conditional Visibility: This feature will only be visible for existing configurations that are already utilizing the notification delay, ensuring backward compatibility.
• Guidance for New Configurations: For new setups or those not using the delay, a new message directs users to leverage notification events for similar functionality, aligning with the planned transition.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies the admin feed settings to limit the visibility of the 'Send Notifications Delay' option, showing it only for feeds that already have delayed notifications configured. This is a good step towards deprecating the feature. My review found a critical issue where an undefined variable is used, which would cause a fatal error. I've provided a code suggestion to fix this and also improve the code structure. I've also included a minor suggestion to improve code conciseness.