fix(mcp): fix index check and remove dead metrics module

MCP install/start checked for a local `vectors` directory (LanceDB
artifact) that no longer exists with Antfly. Switch to metadata.json.

Remove the entire metrics module (MetricsStore, analytics, collector,
schema, types, service) — it was write-only with no consumers after
removing `dev stats` and the dashboard. Drops better-sqlite3 native
dependency (-36 transitive packages, -2400 lines).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: prosdev

packages/cli/src/commands/index.ts

@@ -1,11 +1,8 @@
-import { join, resolve } from 'node:path';
+import { resolve } from 'node:path';
 import {
-  AsyncEventBus,
   ensureStorageDirectory,
   getStorageFilePaths,
   getStoragePath,
-  type IndexUpdatedEvent,
-  MetricsStore,
   RepositoryIndexer,
   updateIndexedStats,
 } from '@prosdevlab/dev-agent-core';
@@ -72,29 +69,13 @@ export const indexCommand = new Command('index')
       await ensureStorageDirectory(storagePath);
       const filePaths = getStorageFilePaths(storagePath);
 
-      // Create event bus for metrics
-      const eventBus = new AsyncEventBus();
-      const metricsDbPath = join(storagePath, 'metrics.db');
-      const metricsStore = new MetricsStore(metricsDbPath);
-
-      eventBus.on<IndexUpdatedEvent>('index.updated', async (event) => {
-        try {
-          metricsStore.recordSnapshot(event.stats, event.isIncremental ? 'update' : 'index');
-        } catch {
-          // Metrics are non-critical — don't fail indexing
-        }
+      const indexer = new RepositoryIndexer({
+        repositoryPath: resolvedRepoPath,
+        vectorStorePath: filePaths.vectors,
+        excludePatterns: config.repository?.excludePatterns || config.excludePatterns,
+        languages: config.repository?.languages || config.languages,
       });
 
-      const indexer = new RepositoryIndexer(
-        {
-          repositoryPath: resolvedRepoPath,
-          vectorStorePath: filePaths.vectors,
-          excludePatterns: config.repository?.excludePatterns || config.excludePatterns,
-          languages: config.repository?.languages || config.languages,
-        },
-        eventBus
-      );
-
       await indexer.initialize();
 
       const indexLogger = createIndexLogger(options.verbose);
@@ -149,7 +130,6 @@ export const indexCommand = new Command('index')
 
       // Finalize
       await indexer.close();
-      metricsStore.close();
 
       await updateIndexedStats(storagePath, {
         files: stats.filesScanned,

packages/cli/src/commands/mcp.ts

@@ -70,13 +70,13 @@ Available Tools (6):
         try {
           // Check if repository is indexed
           const storagePath = await getStoragePath(repositoryPath);
-          const { vectors, watcherSnapshot } = getStorageFilePaths(storagePath);
+          const { vectors, metadata, watcherSnapshot } = getStorageFilePaths(storagePath);
 
-          const vectorsExist = await fs
-            .access(vectors)
+          const isIndexed = await fs
+            .access(metadata)
             .then(() => true)
             .catch(() => false);
-          if (!vectorsExist) {
+          if (!isIndexed) {
             logger.error(`Repository not indexed. Run: ${chalk.yellow('dev index')}`);
             process.exit(1);
           }
@@ -205,15 +205,15 @@ Available Tools (6):
         const spinner = ora(`Installing dev-agent MCP server in ${targetIDE}...`).start();
 
         try {
-          // Check if repository is indexed
+          // Check if repository is indexed (metadata.json is written at index time)
           const storagePath = await getStoragePath(repositoryPath);
-          const { vectors } = getStorageFilePaths(storagePath);
+          const { metadata } = getStorageFilePaths(storagePath);
 
-          const vectorsExist = await fs
-            .access(vectors)
+          const isIndexed = await fs
+            .access(metadata)
             .then(() => true)
             .catch(() => false);
-          if (!vectorsExist) {
+          if (!isIndexed) {
             spinner.fail(`Repository not indexed. Run: ${chalk.yellow('dev index')}`);
             process.exit(1);
           }

packages/cli/src/commands/storage.ts

@@ -99,11 +99,9 @@ Storage Location:
   Each repository gets its own subdirectory based on path hash
   
 What's Stored:
-  • vectors.lance/        Vector embeddings for semantic search
-  • indexer-state.json    Repository indexing state
-  • github-state.json     GitHub issues/PRs state
   • metadata.json         Repository metadata
-  • metrics.db            Historical metrics (SQLite)
+
+  Vector data is stored in Antfly (local search backend).
 `
   );
 

packages/core/package.json

@@ -30,7 +30,6 @@
     "test:watch": "vitest"
   },
   "devDependencies": {
-    "@types/better-sqlite3": "^7.6.13",
     "@types/mdast": "^4.0.4",
     "@types/node": "^24.10.1",
     "tree-sitter-wasms": "^0.1.13",
@@ -40,7 +39,6 @@
     "@antfly/sdk": "0.0.14",
     "@prosdevlab/dev-agent-types": "workspace:*",
     "@prosdevlab/kero": "workspace:*",
-    "better-sqlite3": "^12.5.0",
     "globby": "^16.0.0",
     "remark": "^15.0.1",
     "remark-parse": "^11.0.0",

packages/core/src/events/types.ts

@@ -6,7 +6,6 @@
  */
 
 import type { DetailedIndexStats } from '../indexer/types.js';
-import type { CodeMetadata } from '../metrics/types.js';
 
 /**
  * Event handler function type
@@ -148,8 +147,6 @@ export interface IndexUpdatedEvent {
   stats: DetailedIndexStats;
   /** Whether this was an incremental update (vs full index) */
   isIncremental?: boolean;
-  /** Per-file code metadata for metrics storage */
-  codeMetadata?: CodeMetadata[];
 }
 
 export interface IndexErrorEvent {

packages/core/src/index.ts

@@ -5,7 +5,6 @@ export * from './context';
 export * from './events';
 export * from './indexer';
 export * from './map';
-export * from './metrics';
 export * from './observability';
 export * from './scanner';
 export * from './services';