Skip to content

Commit 7bcb1d5

Browse files
prosdevclaude
andcommitted
fix(agents): address code review feedback on MCP tool assignments
- Fix checklist phrasing in logic-reviewer to match boolean assertion style - Make quick-scout workflow more prescriptive for haiku model - Bump security-reviewer dev_refs to high-impact (taint tracking) - Drop unused dev_health and dev_status columns from matrix - Add footnote explaining code-reviewer is an orchestrator Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 22a3fd6 commit 7bcb1d5

4 files changed

Lines changed: 21 additions & 19 deletions

File tree

.claude/agents/logic-reviewer.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ Use `dev_refs` to trace caller/callee chains across package boundaries. Use `dev
7070
- [ ] Core exports consumed correctly by CLI, MCP server, and subagents — verify with `dev_refs`
7171
- [ ] Type boundaries between packages match (no `any` casting to bridge mismatches)
7272
- [ ] Logger (@prosdevlab/kero) configuration consistent across consumers
73-
- [ ] Use `dev_patterns` to check if error handling patterns are consistent with existing code
73+
- [ ] Error handling patterns are consistent with existing code (verify with `dev_patterns`)
7474

7575
## Design Echo Pass (Deep+ Effort)
7676

.claude/agents/pr-composer.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
name: pr-composer
33
description: "Prepares code for pull request. Runs validation, reviews diff, and composes PR description. Use after completing a feature or fix."
4-
tools: Read, Glob, Grep, Bash, mcp__dev-agent__dev_map, mcp__dev-agent__dev_status
4+
tools: Read, Glob, Grep, Bash, mcp__dev-agent__dev_map
55
model: sonnet
66
---
77

@@ -31,7 +31,7 @@ git diff main...HEAD
3131
git log main..HEAD --oneline
3232
```
3333

34-
Use `dev_map` to understand the structural impact of changes and identify which areas of the codebase were modified. Use `dev_status` to verify the index is healthy before PR.
34+
Use `dev_map` to understand the structural impact of changes and identify which areas of the codebase were modified.
3535

3636
Review all changes for:
3737

.claude/agents/quick-scout.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ Do NOT guess at architectural reasoning or make recommendations.
2525

2626
## Workflow
2727

28-
1. **Search**Start with `dev_search` for conceptual queries ("authentication flow", "error handling"). Fall back to Grep for exact string matches and Glob for file patterns.
29-
2. **Trace**Use `dev_refs` to find callers/callees when tracing usage across packages. Faster and more complete than grepping for function names.
30-
3. **Map**Use `dev_map` when asked about codebase structure or to identify high-churn areas.
28+
1. **Search**Always start with `dev_search`. It finds code by meaning, not just keywords. Only fall back to Grep for exact string matches or Glob for file patterns.
29+
2. **Trace**For "who calls X?" or "what does X call?", use `dev_refs`. Do not grep for function names when `dev_refs` can trace the graph directly.
30+
3. **Map**For "what's the structure?" or "what changed recently?", use `dev_map`.
3131
4. **Verify** — Read the file to confirm the match
3232
5. **Report** — Concise, factual answer with file paths and line numbers
3333

CLAUDE.md

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -107,19 +107,21 @@ research-planner — investigation planning before implementation
107107
Agents dogfood the dev-agent MCP tools. ★ = high impact, ● = useful.
108108

109109
```
110-
┌───────────────────┬────────────┬──────────┬─────────┬──────────────┬────────────┬────────────┐
111-
│ Agent │ dev_search │ dev_refs │ dev_map │ dev_patterns │ dev_status │ dev_health │
112-
├───────────────────┼────────────┼──────────┼─────────┼──────────────┼────────────┼────────────┤
113-
│ bug-investigator │ ★ │ ★ │ ● │ │ │ │
114-
│ quick-scout │ ★ │ ★ │ ● │ │ │ │
115-
│ research-planner │ ★ │ ● │ ★ │ ★ │ │ │
116-
│ logic-reviewer │ ● │ ★ │ │ ● │ │ │
117-
│ security-reviewer │ ★ │ ● │ │ ★ │ │ │
118-
│ quality-reviewer │ ● │ │ │ ★ │ │ │
119-
│ plan-reviewer │ │ ★ │ ★ │ ● │ │ │
120-
│ pr-composer │ │ │ ● │ │ ● │ │
121-
│ code-reviewer │ │ │ │ │ │ │
122-
└───────────────────┴────────────┴──────────┴─────────┴──────────────┴────────────┴────────────┘
110+
┌───────────────────┬────────────┬──────────┬─────────┬──────────────┐
111+
│ Agent │ dev_search │ dev_refs │ dev_map │ dev_patterns │
112+
├───────────────────┼────────────┼──────────┼─────────┼──────────────┤
113+
│ bug-investigator │ ★ │ ★ │ ● │ │
114+
│ quick-scout │ ★ │ ★ │ ● │ │
115+
│ research-planner │ ★ │ ● │ ★ │ ★ │
116+
│ logic-reviewer │ ● │ ★ │ │ ● │
117+
│ security-reviewer │ ★ │ ★ │ │ ★ │
118+
│ quality-reviewer │ ● │ │ │ ★ │
119+
│ plan-reviewer │ │ ★ │ ★ │ ● │
120+
│ pr-composer │ │ │ ● │ │
121+
│ code-reviewer* │ │ │ │ │
122+
└───────────────────┴────────────┴──────────┴─────────┴──────────────┘
123+
124+
* code-reviewer is an orchestrator — it delegates to security/logic/quality reviewers.
123125
```
124126

125127
---

0 commit comments

Comments
 (0)