Skip to content

Commit cf40eb5

Browse files
prosdevclaude
andcommitted
docs(plans): address plan-reviewer recommendations
- Pin @antfly/sdk to exact version (0.0.14, not ^0.0.14) - Add RepositoryIndexer.initialize() to Part 1.3 surface area - Add getAll() pagination and embedding completion as spike questions - Add model mismatch detection test to Part 1.2 - Add concurrent auto-start safety to Part 1.5 - All reviewer findings addressed Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 53104fb commit cf40eb5

5 files changed

Lines changed: 8 additions & 2 deletions

File tree

.claude/da-plans/core/phase-1-antfly-migration/1.1-spike-validate-api.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,8 @@ If there's a delay, we need to handle this in the index command (wait for embedd
145145
| 6 | Can we full-scan without a query vector? | |
146146
| 7 | Does the SDK handle connection errors gracefully? | |
147147
| 8 | What happens when antfly server is not running? | |
148+
| 9 | Does `getAll()` paginate beyond 10000 docs? How? | |
149+
| 10 | Does `dev index` need to wait for embedding completion before returning? | |
148150

149151
## Exit criteria
150152

.claude/da-plans/core/phase-1-antfly-migration/1.2-antfly-vector-store.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@ Use a dedicated test table (`test-antfly-{random}`), clean up after each test.
187187
| handles empty table search | search on empty table → returns [] |
188188
| handles missing server gracefully | Connection refused → meaningful error |
189189
| search(embedding) throws | Direct call to search() with vector → throws with guidance |
190+
| detects model mismatch | Table has model A, config says model B → warns user to re-index |
190191

191192
## Exit criteria
192193

.claude/da-plans/core/phase-1-antfly-migration/1.3-update-facade.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ so consumers don't change.
1010

1111
- `packages/core/src/vector/index.ts` — VectorStorage class
1212
- `packages/core/src/vector/types.ts` — VectorStorageConfig, VectorStats
13+
- `packages/core/src/indexer/index.ts` — RepositoryIndexer.initialize() passes skipEmbedder
1314

1415
## Current flow (VectorStorage.add)
1516

.claude/da-plans/core/phase-1-antfly-migration/1.4-swap-deps-tests.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Remove:
1818

1919
Add:
2020
```json
21-
"@antfly/sdk": "^0.0.14"
21+
"@antfly/sdk": "0.0.14"
2222
```
2323

2424
### packages/dev-agent/package.json
@@ -31,7 +31,7 @@ Remove:
3131

3232
Add:
3333
```json
34-
"@antfly/sdk": "^0.0.14"
34+
"@antfly/sdk": "0.0.14"
3535
```
3636

3737
### packages/dev-agent/tsup.config.ts

.claude/da-plans/core/phase-1-antfly-migration/1.5-dev-setup-command.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,7 @@ If antfly is installed but not running, it auto-starts silently.
244244
| ensureAntfly — server not running, binary exists | Mock fetch fail → spawn called → poll succeeds |
245245
| ensureAntfly — binary missing | Mock execSync throw → error with install instructions |
246246
| ensureAntfly — server fails to start in time | Mock poll timeout → error message |
247+
| ensureAntfly — concurrent calls | Two simultaneous calls → only one spawns, second detects running server |
247248
| dev setup — model missing | Mock termite list → triggers pull |
248249
| dev setup — everything ready | All checks pass → "Nothing to do" |
249250
@@ -255,3 +256,4 @@ If antfly is installed but not running, it auto-starts silently.
255256
- Antfly binary missing → clear error pointing to install instructions
256257
- No user-facing command requires typing `antfly` directly
257258
- `ANTFLY_URL` env var works for custom setups
259+
- Concurrent auto-start is safe (check port before spawning, brief retry delay)

0 commit comments

Comments
 (0)