Skip to content

Commit f1fe8c7

Browse files
prosdevclaude
andcommitted
docs: fix S1, S2, S3 from review — context passing, agent types, frontmatter
S1: code-reviewer passes Phase 1 findings to specialists in task brief so they skip re-querying dev_refs/dev_map S2: research-planner clarifies general-purpose is a Claude Code built-in subagent type (default when no subagent_type specified) S3: Part 2.4 specifies exact tools: frontmatter changes for each agent Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent d07f203 commit f1fe8c7

3 files changed

Lines changed: 56 additions & 16 deletions

File tree

.claude/agents/code-reviewer.md

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,19 +39,27 @@ Based on what you learned, write **specific focused tasks** for each specialist.
3939
Do NOT send them the same generic "review the diff" prompt. Tell each one exactly
4040
what to focus on.
4141

42+
**Include your Phase 1 findings in each task brief.** The specialists have MCP tools
43+
too, but they should NOT re-query what you already gathered. Pass them the callers,
44+
hot path rank, and pattern context you found — so they focus on judgment, not data
45+
gathering.
46+
4247
Example — bad (generic):
4348
> "security-reviewer: review the diff for security issues"
4449
45-
Example — good (focused):
50+
Example — good (focused, includes Phase 1 context):
4651
> "security-reviewer: This PR adds a new `resolveTarget` function that runs
4752
> `execSync('git diff ...')` with user-provided input at refs.ts:67. Check for
4853
> command injection. Also review the new `graphPath` config that's passed from
49-
> user config to fs.readFile at review-analysis.ts:42."
54+
> user config to fs.readFile at review-analysis.ts:42.
55+
>
56+
> Context from my analysis: this file has 12 downstream consumers (high impact).
57+
> The execSync call is the only shell invocation in the diff."
5058
5159
Write focused tasks for:
52-
- **security-reviewer** — point it at specific user input paths, shell commands, file access
53-
- **logic-reviewer** — point it at specific error handling, race conditions, edge cases you spotted
54-
- **quality-reviewer** — point it at specific test gaps, naming inconsistencies, convention deviations
60+
- **security-reviewer** — point it at specific user input paths, shell commands, file access. Include which files are high-impact.
61+
- **logic-reviewer** — point it at specific error handling, race conditions, edge cases. Include the callers/callees you found.
62+
- **quality-reviewer** — point it at specific test gaps, naming inconsistencies. Include the pattern comparison results.
5563

5664
### Phase 3: Delegate in parallel
5765

.claude/agents/research-planner.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,10 @@ Plan 2-4 research tasks. Each should:
6666

6767
### Phase 3: Delegate research in parallel
6868

69-
Launch sub-agents via the Agent tool, one per research task. Use the
70-
`general-purpose` agent type. Give each a precise brief:
69+
Launch sub-agents via the Agent tool, one per research task. These use
70+
Claude Code's built-in `general-purpose` subagent type (not a custom agent
71+
definition — it's the default when no `subagent_type` is specified).
72+
Give each a precise brief:
7173

7274
```
7375
Agent 1: "Search GitHub for how [specific project] implements [specific thing].

.claude/da-plans/mcp/phase-2-composite-tools/2.4-docs-and-agents.md

Lines changed: 39 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,19 +39,49 @@ Update CLI commands section to include `dev review` and `dev research`.
3939

4040
Update Agent → MCP Tool Matrix to show which agents benefit from composite tools.
4141

42-
### Agent updates
42+
### Agent updates — specific frontmatter changes
4343

44-
**code-reviewer.md** — Use `dev_review` instead of manually orchestrating 3 reviewers.
45-
The `dev_review` MCP tool gives each sub-agent the context it needs in one call.
44+
**code-reviewer.md** — Add `mcp__dev-agent__dev_review` to `tools:` frontmatter.
45+
Use `dev_review` in Phase 1 to gather impact/patterns/structure in one call
46+
instead of calling `dev_refs` + `dev_map` + `dev_patterns` separately.
4647

47-
**research-planner.md** — Use `dev_research` as the first step to map the territory.
48-
Replaces the manual `dev_map` + `dev_search` + `dev_patterns` workflow.
48+
```yaml
49+
# Current tools:
50+
tools: Read, Grep, Glob, Bash, mcp__dev-agent__dev_search, mcp__dev-agent__dev_refs, mcp__dev-agent__dev_map, mcp__dev-agent__dev_patterns
51+
# Add:
52+
tools: ..., mcp__dev-agent__dev_review
53+
```
54+
55+
**research-planner.md** — Add `mcp__dev-agent__dev_research` to `tools:` frontmatter.
56+
Use `dev_research` in Phase 1 to map the territory in one call.
57+
58+
```yaml
59+
# Current tools:
60+
tools: Read, Grep, Glob, Bash, mcp__dev-agent__dev_search, mcp__dev-agent__dev_refs, mcp__dev-agent__dev_map, mcp__dev-agent__dev_patterns
61+
# Add:
62+
tools: ..., mcp__dev-agent__dev_research
63+
```
4964

50-
**bug-investigator.md**Use `dev_research "error in <component>"` to quickly gather
51-
all relevant context for a bug investigation.
65+
**bug-investigator.md** — Add `mcp__dev-agent__dev_research` to `tools:` frontmatter.
66+
Use `dev_research "error in <component>"` to quickly gather all relevant context.
5267

53-
**plan-reviewer.md** — Use `dev_review` to verify that plan claims match actual
54-
codebase state.
68+
```yaml
69+
# Current tools:
70+
tools: Read, Edit, Write, Glob, Grep, Bash, mcp__dev-agent__dev_search, mcp__dev-agent__dev_refs, mcp__dev-agent__dev_map
71+
# Add:
72+
tools: ..., mcp__dev-agent__dev_research
73+
```
74+
75+
**plan-reviewer.md** — Add `mcp__dev-agent__dev_review` to `tools:` frontmatter.
76+
Use `dev_review` to verify that plan claims about file impact and conventions
77+
match actual codebase state.
78+
79+
```yaml
80+
# Current tools:
81+
tools: Read, Grep, Glob, Bash, mcp__dev-agent__dev_refs, mcp__dev-agent__dev_map, mcp__dev-agent__dev_patterns
82+
# Add:
83+
tools: ..., mcp__dev-agent__dev_review
84+
```
5585

5686
### `website/content/updates/index.mdx`
5787

0 commit comments

Comments
 (0)