Pin @JsonProperty on FRAGILE wire DTO record components (#52)#60
Merged
Conversation
Add explicit @JsonProperty("<name>") on every record component flagged FRAGILE by the wire-DTO conformance audit, so the JSON contract no longer depends on incidental agreement between Java component names and gwt-ui client field names. A future rename on either side will now surface as an explicit contract change instead of silently deserializing as null. Covers all 58 backend files listed in #52 (two already had the annotation, so 56 files actually change here). Closes #52 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@JsonProperty("<name>")to every record component flaggedFRAGILEby the wire-DTO conformance audit (issue Pin @JsonProperty on all naked record components flagged as FRAGILE by the wire-DTO conformance audit (58 records) #52), so the JSON contract no longer depends on incidental agreement between Java component names and the gwt-ui client.GetDeprecatedEntitiesAction,PerformEntitySearchAction) already had the annotation, so 56 files actually change here.GetDeprecatedEntitiesAction/PerformEntitySearchAction.A renaming of either the Java component or the matching gwt-ui field will now break the wire contract loudly instead of silently deserializing as
null.Test plan
mvn -q -DskipTests compilepasses.webprotege-gwt-uilands together (26 files; covered separately).tools/audit_json_conformance.pyand confirmFRAGILE=0and noMATCHrow regresses toNAME_MISMATCH.