ci: route Linux runner through NSC_RUNNER variable#13
Closed
mabry1985 wants to merge 1 commit into
Closed
Conversation
Replaces hardcoded `runs-on: namespace-profile-protolabs-linux` with
`${{ vars.NSC_RUNNER || 'namespace-profile-protolabs-linux' }}`, matching
the override pattern already standard across the plugin repos.
No behavior change: with NSC_RUNNER unset, jobs still run on Namespace.
This lets the whole fleet move to self-hosted runners by setting a single
org-level Actions variable instead of editing every workflow.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #13 | ci: route Linux runner through NSC_RUNNER variable
VERDICT: WARN (non-terminal CI — verify queued; otherwise clean)
CI Status
- bump: skipped
- verify: queued
Diff Review
.github/workflows/verify-bundle.yml: Tworuns-onlines converted from hardcoded Namespace runner to${{ vars.NSC_RUNNER || 'namespace-profile-protolabs-linux' }}. Pattern matches org standard. Fallback preserves current behavior whenNSC_RUNNERis unset — no regression risk.
Observations
- LOW: clawpatch_review unavailable for this repo (502). Diff is small enough (2 lines) that direct review is sufficient.
- No HIGH or CRITICAL findings.
— Quinn, QA Engineer
|
Submitted COMMENT review on #13. |
Quinn Bug Triage — Closing as stale (not_planned)This PR was approved and CI-green on June 24 (10 days stale) but was never merged. The change (CI runner override via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route Linux runner through
NSC_RUNNERPart of the org-wide migration off Namespace toward self-hosted runners.
Converts hardcoded
runs-on: namespace-profile-protolabs-linuxto the override pattern already standard in the plugin repos:No behavior change today — with
NSC_RUNNERunset, every job still runs on Namespace. Once self-hosted runners are live, setting the org-levelNSC_RUNNERvariable moves the entire fleet at once, with no further workflow edits.Converted 2 workflow line(s) in this repo.
🤖 Generated with Claude Code