docs: gateway inheritance makes team_template optional + one-pick archetype#14
Merged
Merged
Conversation
…hetype note With portfolio v0.14 a spawned team inherits the PM's own resolved gateway (+ its OPENAI_API_KEY via the team's env), so team_template is now OPTIONAL — empty is the happy path and a team runs real turns with zero creds prep. Reframe the bundle config comment + README Install block accordingly (team_template = a per-team-gateway escape hatch, not a prerequisite), and note the one-pick 'Portfolio Manager' archetype setup. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #14 | docs: gateway inheritance makes team_template optional + one-pick archetype
VERDICT: WARN
CI Status
- bump: skipped
- verify: queued
Diff Review
protoagent.bundle.yaml: comment-only change —team_templatere-documented for portfolio v0.14 gateway inheritance; value unchanged ("")README.md: drops the creds-prep instruction, adds one-pick archetype setup note; no functional changes- No code, pin, or logic changes — purely docs/comments
Observations
- GAP: docs reference portfolio v0.14 gateway inheritance behavior that depends on unmerged PR protoLabsAI/portfolio-plugin#17. The PR description acknowledges this and defers the
ref: portfolio v0.14.0pin bump. Docs may be ahead of reality until that lands. - No functional, security, or correctness concerns — clean docs-only PR.
— Quinn, QA Engineer
|
Submitted COMMENT review on #14. |
mabry1985
added a commit
that referenced
this pull request
Jul 1, 2026
Picks up gateway inheritance (protoLabsAI/portfolio-plugin#17): a spawned team inherits the PM's own resolved gateway + OPENAI_API_KEY, so portfolio_spinup_team runs real turns with no team_template / creds prep. The bundle docs (#14) already describe this. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reframes the Portfolio Manager setup docs around portfolio v0.14 gateway inheritance: a spawned team now inherits the PM's own resolved gateway (+ its
OPENAI_API_KEYvia the team's environment), so it runs real model turns with zero creds prep.protoagent.bundle.yaml— theconfig.portfolio.team_templatecomment now says empty is the happy path;team_templateis a per-team-gateway escape hatch, not a prerequisite. (Value unchanged — still"".)team_templateat a creds-filled copy" instruction; empty just works. Adds a one-pick setup note: installing the bundle registers the "Portfolio Manager" archetype, so the new-agent picker gives you a configured PM with no YAML.Docs/comments only — no functional or pin changes. The
ref: portfolio v0.14.0pin bump follows once PR #17 merges and tags (the scheduled bundle-bump job opens that PR).🤖 Generated with Claude Code