chore: bump portfolio pin v0.14.1 → v0.14.2 (protoAgent ≥ 0.77 compat)#17
Conversation
… verified_against 0.81.0 portfolio v0.14.2 fixes the dashboard 500 on protoAgent >= 0.77 (scope_leaf was deleted in protoAgent#1481; the plugin's PM data stores now resolve via instance_paths().store() with a legacy fallback). verified_against trued up to the 0.81.0 host this pin set is being proven on. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #17 | chore: bump portfolio pin v0.14.1 → v0.14.2 (protoAgent ≥ 0.77 compat)
VERDICT: WARN (non-terminal CI — verify still queued; re-review on settle)
CI Status
- bump: skipped
- verify: queued ⏳
Diff Review
protoagent.bundle.yaml: portfolio pinv0.14.1→v0.14.2(fixes dashboard 500 — removes legacyscope_leafimport deleted in protoAgent#1481/ADR 0065)verified_against:0.66.0→0.81.0— aligns recorded verification target with the actual smoke-test host generation
Observations
- LOW: The
verifyjob is the real regression gate here — it installs this manifest into a scratch agent and probes console views. Blocking verdict should wait on its terminal state. No issues visible in the diff itself. - No unresolved CodeRabbit threads. No structural concerns — single-file, two-line version bump with clear release-linkage rationale.
— Quinn, QA Engineer
|
Submitted COMMENT review on #17. |
… a dead data layer) The view probe asserts the PAGE serves 200, but portfolio v0.14.1's page did serve 200 while every /api/plugins/portfolio/* data route 500'd (the deleted scope_leaf import) — verify stayed green while the dashboard was dead. Now every parameterless GET route under an ENABLED member's gated prefix must answer <500. Carried-but-off members (project_board, agent_browser) are exempt: their data layers legitimately need runtime state (a bound repo, a browser) the scratch agent doesn't have. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Added a second commit closing the gap that let this regression through: |
There was a problem hiding this comment.
QA Audit — PR #17 | chore: bump portfolio pin v0.14.1 → v0.14.2 (protoAgent ≥ 0.77 compat)
VERDICT: WARN (non-terminal CI — verify in_progress; tentative PASS on substance)
CI Status
- bump: skipped
- verify: in_progress ⏳
Diff Review
protoagent.bundle.yaml: portfolio pin bumped v0.14.1 → v0.14.2, matching the v0.14.2 release that drops the legacyscope_leafimport broken in protoAgent ≥ 0.77.verified_againsttrued to 0.81.0 — consistent with the verify workflow targeting protoAgent main.scripts/verify_bundle.py: adds data-route probing for enabled members (GET parameterless routes under/api/plugins/<id>/). This catches the exact 500-via-ImportError class of bug this pin bump fixes — the old verify only probed view pages, which served 200 while the data layer was dead.
Observations
- LOW: verify job still running — re-review when CI is terminal-green. Substance of the diff is clean and well-scoped.
No unresolved CodeRabbit threads. No security concerns. The verify script correctly excludes carried-but-off members (project_board, agent_browser) whose routes legitimately need runtime state.
— Quinn, QA Engineer
|
Submitted COMMENT review on |
1 participant
Moves the
portfoliopin to v0.14.2, which fixes the dashboard 500 on protoAgent ≥ 0.77: the plugin still imported the legacyscope_leafknob (deleted in protoAgent#1481, ADR 0065), so every/api/plugins/portfolio/*data route raisedImportError— the console view died with WebKit'sSyntaxError: The string did not match the expected pattern. Found by installing pm-stack on a fresh 0.81.0 desktop workspace.Also trues up
verified_against: 0.66.0 → 0.81.0— the verify job runs against protoAgentmain(0.81.x), so this records the host generation the pin set actually proves itself on.The
verifyjob on this PR is the real regression test: it installs this manifest into a scratch agent on current protoAgent and probes the declared console views.🤖 Generated with Claude Code