feat: enable the github plugin at the manager tier#25
Merged
Conversation
A portfolio manager's job includes filing/triaging issues -- an external dependency, a cross-repo ask, a bug needing a human's call -- not just orchestrating teams. Add github-plugin (read+write GitHub tools over `gh`) to the bundle, enabled by default alongside delegates + portfolio. github ships `write: false` by default as its own operator-trust gate; this bundle opts in (`config.github.write: true`) since triage explicitly needs comment/label, and issue-filing needs create -- both PM-tier work. Merge itself stays confirm-guarded by the plugin regardless. No default_repo/repos baked in -- those are per-instance operator config. Added a soul bullet so a spun-up PM knows to reach for it. Verified locally: scripts/verify_bundle.py against a fresh protoAgent checkout -- 4 members (portfolio, github, project_board, agent_browser) installed+loaded, every declared view 200, every enabled data route <500. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
There was a problem hiding this comment.
QA Audit — PR #25 | feat: enable the github plugin at the manager tier
VERDICT: WARN (CI non-terminal — verify queued)
CI Status
- bump: skipped
- verify: queued
Diff Review
- Single-file change:
protoagent.bundle.yaml— addsgithub-pluginv0.1.3 (pinned), enables it alongsidedelegates+portfolio, setswrite: truewith clear rationale, and adds a soul bullet to the archetype. - Plugin ref is pinned, config section is well-commented, no stale/untracked debris concerns (PR description addresses the
__pycache__false positive from protoAgent#1336).
Observations
- GAP: CI
verifyis still queued — re-review will confirm once terminal. Local verification (documented) covers the same path. - LOW: The
write: trueopt-in is correctly scoped — merge remainsconfirm-guarded by the plugin regardless, so this is an explicit trust decision at the bundle level, not a risk escalation.
— Quinn, QA Engineer
|
Submitted COMMENT review on #25. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
github-plugin(read+write GitHub tools overgh) to the pm-stack bundle, enabled by default alongsidedelegates+portfolio.A portfolio manager's job includes filing/triaging issues — an external dependency, a cross-repo ask, a bug that needs a human's call — not just orchestrating teams.
project_board/agent_browserstay installed-but-off (team-tier only, discovered via the host's plugins dir);githubis manager-tier work, so it's enabled at the bundle level.Config
github-pluginshipswrite: falseby default as its own operator-trust gate (per-agent, ADR 0019); this bundle makes the trust decision explicit since it's exactly the PM-tier's job. Merge itself staysconfirm-guarded by the plugin regardless of this setting. Nodefault_repo/reposbaked in — those are per-instance operator config (which repos this PM watches).Also added a soul bullet so a PM spun up from this bundle actually knows to reach for the capability, not just have it silently available.
Verification
Ran the bundle's own
scripts/verify_bundle.pylocally against a freshprotoAgentcheckout (what CI'sverify-bundle.ymldoes):Note for future readers: a stale local
plugins/github/__pycache__(leftover from before GitHub was retired from protoAgent core in #1336) briefly made the installer thinkgithubcollided with a built-in — that's untracked/gitignored local debris, not a real conflict; a fresh CI checkout doesn't have it, confirmed by removing the debris and re-running clean.🤖 Generated with Claude Code