refactor: pm-stack → Portfolio Manager bundle (manager-of-teams tier)#9
Merged
Conversation
Closes the cross-board loop — auto-dispatch held work once its dependency ships (planned-dispatch links + idempotent portfolio_autodispatch). ADR 0055 P3. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ier) Completes the portfolio→team split (ADR 0055). The Lead Engineer bundle is the team tier (project_board + a repo's coding agents); pm-stack is now the manager tier that orchestrates + SPAWNS those teams. - enabled: [delegates, portfolio] — the manager spine only (was: also project_board + agent_browser). The PM runs no board of its own. - project_board + agent_browser stay INSTALLED but off: a spawned team's plugins.dir defaults to this host's plugins dir, so the teams the PM spins up discover them here without a per-team reinstall. Install once, provision many teams. - portfolio pinned v0.5.0 → v0.7.2 (the team-spawning release: portfolio_spinup_team / teardown_team / autodispose / teams). - archetype: Project Manager → Portfolio Manager, with a starting SOUL (the spin-up / dispatch / roll-up / sequence / dispose loop). - config: portfolio.team_template wired (empty → the plugin's shipped example; point it at a creds-filled copy for teams that run real model turns). - verified_against 0.35.3 → 0.66.0. README rewritten for the manager tier. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
There was a problem hiding this comment.
QA Audit — PR #9 | refactor: pm-stack → Portfolio Manager bundle (manager-of-teams tier)
VERDICT: PASS
CI Status
- No CI checks found (Gap — repo may not have CI configured)
Diff Review
- Clean manifest refactor:
enablednarrowed to manager tier[delegates, portfolio]; team plugins (project_board,agent_browser) stay installed-but-disabled for spawned-team discovery — consistent with ADR 0055 - portfolio pin v0.4.0 → v0.7.2;
verified_against0.35.3 → 0.66.0; archetype relabeled as Portfolio Manager withsoul - README fully rewritten for the manager-of-teams tier with spin-up/dispatch/autodispose examples — clear and accurate
Observations
- GAP: No CI checks —
verified_against: 0.66.0claim cannot be confirmed; verify manually before relying on this bundle - GAP: portfolio-plugin tag v0.7.2 unverified (tooling can't reach external repos) — confirm the tag exists and carries the claimed
portfolio_spinup_team/autodisposetools - GAP: Clawpatch structural review unavailable (pm-stack not in project registry) — no cross-file analysis beyond diff inspection
- LOW: PR claims "Generated with Claude Code" — manifest refactor is low-risk and well-documented, but human sign-off on the
verified_againstbump is advisable
— Quinn, QA Engineer
|
Submitted APPROVE review on |
…nager-bundle # Conflicts: # protoagent.bundle.yaml
There was a problem hiding this comment.
QA Audit — PR #9 | refactor: pm-stack → Portfolio Manager bundle (manager-of-teams tier)
VERDICT: WARN
CI Status
- verify: queued
Diff Review
- Pure manifest + docs refactor (2 files, 217 lines); no executable code changes.
protoagent.bundle.yaml:enablednarrowed to[delegates, portfolio]— manager spine only.project_board+agent_browserstay installed-but-off as a discovery layer for spawned teams. Rationale documented inline.portfoliopinned v0.5.0 → v0.7.2 (team-spawning release);verified_against0.35.3 → 0.66.0. README rewritten for the manager-tier narrative with usage examples.- Archetype updated: label, icon, blurb, and a new
soulpersona.
Observations
- LOW: Clawpatch structural review unavailable —
protoLabsAI/pm-stacknot in the project registry. Proceeding with diff-level review only. - LOW:
verified_againstjumps from 0.35.3 to 0.66.0 (~30 minor versions). TheverifyCI check is still queued — no smoke-test confirmation yet that this pin set actually works against protoAgent 0.66.0. Once CI passes, this concern evaporates. - LOW:
portfolio.team_templatedefaults to empty string, which falls back to the plugin's shipped example. This is a sensible default, but the comment suggests pointing it at a creds-filled copy for real model turns — worth calling out in the README's Install section (already done).
No blocking issues. The design is consistent with ADR 0055 and the documentation is clear. Awaiting CI completion for final PASS/FAIL.
— Quinn, QA Engineer
|
Submitted COMMENT review on #9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes the portfolio→team split (ADR 0055). The Lead Engineer bundle is the team tier (project_board + a repo's coding agents); pm-stack is now the manager tier that orchestrates and spawns those teams.
Changes
enabled: [delegates, portfolio]— the manager spine only (was: also project_board + agent_browser). The PM runs no board of its own.plugins.dirdefaults to this host's plugins dir, so the teams the PM spins up discover them here without a per-team reinstall. Install once, provision many teams.portfolio_spinup_team/teardown_team/autodispose/teams).soul(the spin-up → dispatch → roll-up → sequence → dispose loop).portfolio.team_templatewired — empty falls back to the plugin's shipped example; point it at a creds-filled copy for teams that run real model turns.verified_against0.35.3 → 0.66.0; README rewritten for the manager tier.One-liner it enables
🤖 Generated with Claude Code