forked from QwenLM/qwen-code
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(telemetry,ui): reasoning span attribute + collapsed thought summary (Phase 1 of #162) #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
478 changes: 478 additions & 0 deletions
478
docs/superpowers/plans/2026-04-30-p4-compaction-todo-preservation.md
Large diffs are not rendered by default.
Oops, something went wrong.
73 changes: 73 additions & 0 deletions
73
packages/cli/src/ui/components/messages/ConversationMessages.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2025 Qwen Team | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import { describe, expect, it } from 'vitest'; | ||
| import { render } from 'ink-testing-library'; | ||
| import { ThinkMessage, ThinkMessageContent } from './ConversationMessages.js'; | ||
|
|
||
| describe('ThinkMessage', () => { | ||
| it('renders the streaming text expanded while pending', () => { | ||
| const { lastFrame } = render( | ||
| <ThinkMessage | ||
| text="Let me consider this carefully and weigh the options." | ||
| isPending={true} | ||
| contentWidth={80} | ||
| />, | ||
| ); | ||
| const output = lastFrame() ?? ''; | ||
| expect(output).toContain('Let me consider this'); | ||
| // Streaming render uses the existing ⟡ glyph, not the ▸ summary marker. | ||
| expect(output).toContain('⟡'); | ||
| expect(output).not.toContain('thinking ('); | ||
| }); | ||
|
|
||
| it('renders compact "thinking (N chars)" summary once stream finalizes', () => { | ||
| const text = 'reasoning '.repeat(10).trim(); // 99 chars | ||
| const { lastFrame } = render( | ||
| <ThinkMessage text={text} isPending={false} contentWidth={80} />, | ||
| ); | ||
| const output = lastFrame() ?? ''; | ||
| expect(output).toContain('▸'); | ||
| expect(output).toContain(`thinking (${text.length} chars)`); | ||
| // Underlying reasoning text is not rendered inline post-stream. | ||
| expect(output).not.toContain('reasoning reasoning'); | ||
| }); | ||
|
|
||
| it('formats large char counts with thousands separator', () => { | ||
| const text = 'x'.repeat(12_345); | ||
| const { lastFrame } = render( | ||
| <ThinkMessage text={text} isPending={false} contentWidth={80} />, | ||
| ); | ||
| const output = lastFrame() ?? ''; | ||
| expect(output).toContain('thinking (12,345 chars)'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('ThinkMessageContent', () => { | ||
| it('renders the continuation text while pending', () => { | ||
| const { lastFrame } = render( | ||
| <ThinkMessageContent | ||
| text="continued reasoning text" | ||
| isPending={true} | ||
| contentWidth={80} | ||
| />, | ||
| ); | ||
| const output = lastFrame() ?? ''; | ||
| expect(output).toContain('continued reasoning text'); | ||
| }); | ||
|
|
||
| it('renders nothing once stream finalizes (the parent ThinkMessage owns the summary)', () => { | ||
| const { lastFrame } = render( | ||
| <ThinkMessageContent | ||
| text="continued reasoning text" | ||
| isPending={false} | ||
| contentWidth={80} | ||
| />, | ||
| ); | ||
| const output = lastFrame() ?? ''; | ||
| expect(output.trim()).toBe(''); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the task-plan summary on the masking-only path.
When observation masking already gets
maskedundertargetTokens, this branch returnsmaskeddirectly and never callscompactMessages(...), so the new<task-plan>enrichment is skipped on those compaction passes. That defeats the preservation behavior in a common case.Possible fix
🤖 Prompt for AI Agents