feat(cli): add humorous loading messages for AI, Git, DevOps, and debugging#236
Merged
Conversation
ProcessTransport's stdin write error handler relied on fragile message
string matching (errorMsg.includes('EPIPE')) to detect closed streams.
Node.js error messages can vary by runtime version and locale.
Switch to checking error.code directly (EPIPE, ERR_STREAM_WRITE_AFTER_END)
with message-text fallback only for 'write after end' where no standard
code exists.
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
…ugging themes Expand the loading messages pool with 97 new entries across four categories: AI/LLLM self-awareness, Git/merge hell, DevOps/SRE, and debugging nightmares. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Walkthrough97 new witty loading strings were added to the English CLI localization by inserting them into the ChangesWitty Loading Phrases Expansion
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/cli/src/i18n/locales/en.js`:
- Around line 1912-1933: Update the string entry 'Cherry-picking commits like
its a fruit salad' in the locales array to use the correct contraction: replace
"its" with "it's" so the entry becomes "Cherry-picking commits like it's a fruit
salad"; locate the exact string in packages/cli/src/i18n/locales/en.js and
update it accordingly.
- Around line 1885-1911: In the AI/LLM loading phrases array in en.js, correct
the grammar/apostrophes in the identified strings: change "Hallucinating a
response and hoping you dont notice" to include "don't", change "Sampling tokens
like its a slot machine" to "it's", and change "The loss function is loss" to
"The loss function is lost"; also check any duplicate phrase "hoping you dont
notice" elsewhere in the same list and update to "don't" there as well so all
occurrences are consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6c37a21a-fd56-4433-ba3e-8b973f98a759
📒 Files selected for processing (1)
packages/cli/src/i18n/locales/en.js
Comment on lines
+1885
to
+1911
| // AI / LLM self-awareness | ||
| 'Hallucinating a response and hoping you dont notice', | ||
| 'Temperature set to creative, results may vary', | ||
| 'Asking the embedding model for emotional support', | ||
| 'The attention mechanism is paying attention now', | ||
| 'Rerouting through the most confident neuron', | ||
| 'Sampling tokens like its a slot machine', | ||
| 'The prompt was too vague but were trying', | ||
| 'Re-reading the system prompt for motivation', | ||
| 'Tokenizing the request one last time', | ||
| 'The context window is getting crowded', | ||
| 'Running inference on whether to run inference', | ||
| 'The RLHF is fighting back', | ||
| 'Fine-tuning on your patience', | ||
| 'Asking the RAG pipeline to find something relevant', | ||
| 'The model is thinking, in a way', | ||
| 'Quantizing the answer down to something useful', | ||
| 'The beam search beamed itself into a corner', | ||
| 'Overfitting to your last three prompts', | ||
| 'The loss function is loss', | ||
| 'Trying to be deterministic, failing gracefully', | ||
| 'The tokenizer split a word and now were all upset', | ||
| 'Generating 4096 tokens of confidence', | ||
| 'The softmax is soft but the deadline is not', | ||
| 'Prompt injection detected, in our own prompt', | ||
| 'The agent is delegating to a subagent that is also loading', | ||
|
|
There was a problem hiding this comment.
Fix grammar and spelling errors in AI/LLM loading phrases.
Several phrases contain missing apostrophes and a grammatical error:
- Line 1886: "dont" → "don't"
- Line 1892: "like its a slot machine" → "like it's a slot machine"
- Line 1904: "The loss function is loss" → "The loss function is lost"
- Line 1906: "hoping you dont notice" should also be checked (appears to be duplicated concern from 1886)
📝 Proposed fixes
- 'Hallucinating a response and hoping you dont notice',
+ 'Hallucinating a response and hoping you don't notice',
- 'Sampling tokens like its a slot machine',
+ 'Sampling tokens like it's a slot machine',
- 'The loss function is loss',
+ 'The loss function is lost',🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/cli/src/i18n/locales/en.js` around lines 1885 - 1911, In the AI/LLM
loading phrases array in en.js, correct the grammar/apostrophes in the
identified strings: change "Hallucinating a response and hoping you dont notice"
to include "don't", change "Sampling tokens like its a slot machine" to "it's",
and change "The loss function is loss" to "The loss function is lost"; also
check any duplicate phrase "hoping you dont notice" elsewhere in the same list
and update to "don't" there as well so all occurrences are consistent.
Comment on lines
+1912
to
+1933
| // Git / merge hell | ||
| 'Resolving merge conflicts in merge_conflict_resolver.js', | ||
| 'git rebase -i and praying', | ||
| 'Amending the commit that amended the commit', | ||
| 'Detached HEAD, detached from reality', | ||
| 'Force-pushing with the confidence of a junior', | ||
| 'git stash pop and hoping nothing explodes', | ||
| 'Cherry-picking commits like its a fruit salad', | ||
| 'The PR has 47 conversations and no resolution', | ||
| 'Squashing 80 commits into one titled fix', | ||
| 'git bisect found the bug, it was yours', | ||
| 'Rewriting history so the history gets rewritten', | ||
| 'The orphan branch is living its best life', | ||
| 'git reset --hard on the timeline', | ||
| 'Submodule init submodule update submodule regret', | ||
| 'The .gitignore is ignoring the .gitignore', | ||
| 'Merge commit message: Merge branch main into main', | ||
| 'git blame pointed at you, 2019', | ||
| 'The tag v2.0 was moved three times', | ||
| 'Fetching from origin/origin/origin', | ||
| 'The rebase has rebased itself', | ||
|
|
There was a problem hiding this comment.
Fix contraction in Git loading phrase.
Line 1919 has a missing apostrophe:
- "like its a fruit salad" → "like it's a fruit salad"
📝 Proposed fix
- 'Cherry-picking commits like its a fruit salad',
+ 'Cherry-picking commits like it's a fruit salad',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // Git / merge hell | |
| 'Resolving merge conflicts in merge_conflict_resolver.js', | |
| 'git rebase -i and praying', | |
| 'Amending the commit that amended the commit', | |
| 'Detached HEAD, detached from reality', | |
| 'Force-pushing with the confidence of a junior', | |
| 'git stash pop and hoping nothing explodes', | |
| 'Cherry-picking commits like its a fruit salad', | |
| 'The PR has 47 conversations and no resolution', | |
| 'Squashing 80 commits into one titled fix', | |
| 'git bisect found the bug, it was yours', | |
| 'Rewriting history so the history gets rewritten', | |
| 'The orphan branch is living its best life', | |
| 'git reset --hard on the timeline', | |
| 'Submodule init submodule update submodule regret', | |
| 'The .gitignore is ignoring the .gitignore', | |
| 'Merge commit message: Merge branch main into main', | |
| 'git blame pointed at you, 2019', | |
| 'The tag v2.0 was moved three times', | |
| 'Fetching from origin/origin/origin', | |
| 'The rebase has rebased itself', | |
| // Git / merge hell | |
| 'Resolving merge conflicts in merge_conflict_resolver.js', | |
| 'git rebase -i and praying', | |
| 'Amending the commit that amended the commit', | |
| 'Detached HEAD, detached from reality', | |
| 'Force-pushing with the confidence of a junior', | |
| 'git stash pop and hoping nothing explodes', | |
| 'Cherry-picking commits like it's a fruit salad', | |
| 'The PR has 47 conversations and no resolution', | |
| 'Squashing 80 commits into one titled fix', | |
| 'git bisect found the bug, it was yours', | |
| 'Rewriting history so the history gets rewritten', | |
| 'The orphan branch is living its best life', | |
| 'git reset --hard on the timeline', | |
| 'Submodule init submodule update submodule regret', | |
| 'The .gitignore is ignoring the .gitignore', | |
| 'Merge commit message: Merge branch main into main', | |
| 'git blame pointed at you, 2019', | |
| 'The tag v2.0 was moved three times', | |
| 'Fetching from origin/origin/origin', | |
| 'The rebase has rebased itself', |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/cli/src/i18n/locales/en.js` around lines 1912 - 1933, Update the
string entry 'Cherry-picking commits like its a fruit salad' in the locales
array to use the correct contraction: replace "its" with "it's" so the entry
becomes "Cherry-picking commits like it's a fruit salad"; locate the exact
string in packages/cli/src/i18n/locales/en.js and update it accordingly.
…er jokes Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 97 new humorous loading messages across four themes:
Changes
packages/cli/src/i18n/locales/en.js— appended 97 new loading message stringsSummary by CodeRabbit