fix: use error.code instead of message text for stream-closed detection#237
Merged
Conversation
ProcessTransport's stdin write error handler relied on fragile message
string matching (errorMsg.includes('EPIPE')) to detect closed streams.
Node.js error messages can vary by runtime version and locale.
Switch to checking error.code directly (EPIPE, ERR_STREAM_WRITE_AFTER_END)
with message-text fallback only for 'write after end' where no standard
code exists.
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProcessTransport's stdin write error handler relied on fragile message string matching (
errorMsg.includes('EPIPE')) to detect closed streams. Node.js error messages can vary by runtime version and locale.Switch to checking
error.codedirectly (EPIPE,ERR_STREAM_WRITE_AFTER_END) with message-text fallback only for 'write after end' where no standard code exists.Changes
packages/sdk-typescript/src/transport/ProcessTransport.ts— replaced string matching witherror.codechecks