docs(soul): true-up roxy's loop to the current portfolio surface#4
Merged
Conversation
Adds the two capabilities the persona predates: prebuilt team archetypes (one-word spinup, freshened on spawn — portfolio v0.12) and the board enumeration/read tools (portfolio_boards / portfolio_board_read). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #4 | docs(soul): true-up roxy's loop to the current portfolio surface
VERDICT: WARN (non-terminal CI — 5 checks still in progress; re-review once CI settles)
CI Status
- build: ⏳ in_progress
- Lint (ruff + import contracts): ✅ success
- Python tests: ⏳ in_progress
- Verify workspace config: ✅ success
- A2A live smoke (lean tier): ⏳ in_progress
- Fleet integration (multi-instance): ⏳ in_progress
- Web E2E smoke: ⏳ in_progress
- gitleaks (tree): ✅ success
Diff Review
- Docs-only change to
config/SOUL.md— no code, no risk. - Spinup section expanded to document prebuilt
archetypekwarg (accurate per portfolio v0.12). - New "Know my boards" bullet adds
portfolio_boards/portfolio_board_read(accurate). - Dispatch bullet tightened to clarify "to a team's board" — consistent with the new board-awareness language.
Observations
- No findings. Clean docs update, clear prose, no regressions. Pending CI terminal-green for formal PASS.
— Quinn, QA Engineer
|
Submitted COMMENT review on |
There was a problem hiding this comment.
CI terminal-green, no blockers on prior review — auto-approving on green (protoLabsAI#748).
mabry1985
added a commit
that referenced
this pull request
Jul 4, 2026
… off by default (protoLabsAI#1681) (protoLabsAI#1682) Field failure (the Windows saga's problem #4): the gateway's embedding route hung (Cloudflare 524) and every chat turn spun — recall runs pre-model, the embeddings client carried the OpenAI SDK defaults (600s timeout + 2 retries), and the knowledge breaker only counts RETURNED failures, so it never tripped. - graph/llm: dedicated 8s request_timeout + max_retries=0 on the shared embeddings client. The gateway owns retries/fallbacks; app-side retries only multiplied the hang. - knowledge/hybrid_store: warm_probe()/_probe_once() — an off-thread route probe at store construction opens the breaker IMMEDIATELY on failure, so the first turn of an outage pays nothing (previously the first breaker_threshold turns each ate the full transport hang, again after every cooldown). - Default flip: knowledge.embeddings True -> False. Out of the box the app must not depend on an optional gateway route; keyword FTS5 recall works everywhere. Opt-in is one Settings > Knowledge toggle (or knowledge.embeddings: true); explicit configs unaffected. Example config, golden, docs trued up. Closes protoLabsAI#1681. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SOUL predates two portfolio-plugin capabilities roxy now has:
portfolio_spinup_team(name, archetype=…): one-word spinup for often-used repos, freshened on the repo's default branch at spawn.portfolio_boards/portfolio_board_read, the know-your-boards primitives underneath the rollup.Both folded into the "How I work" loop; values/communication unchanged.
🤖 Generated with Claude Code