Commit 3a3af7c
committed
Fix exceljs#3028: make getWorksheet case-insensitive to match addWorksheet
Workbook.addWorksheet enforces case-insensitive name uniqueness (and
Excel itself treats sheet names case-insensitively), but
Workbook.getWorksheet was matching with a case-sensitive ===. As a
result, after addWorksheet("Sheet1"), getWorksheet("sheet1") returned
undefined even though addWorksheet("sheet1") would throw "Worksheet
name already exists".
Lowercase both sides of the string comparison in getWorksheet so any
casing of an existing sheet name resolves to that sheet. Numeric-id
and no-arg branches are unchanged.
Adds spec/integration/issues/issue-3028-getworksheet-case-insensitive.spec.js
covering: mixed casings resolve to the same sheet, unknown names still
return undefined, numeric id and no-arg shortcuts preserved, and the
addWorksheet/getWorksheet contracts now agree.
Drive-by: collapse pre-existing multi-line constructs in the same
function (two console.trace deprecation warnings and an Object.assign
+ a reduce->for loop) so prettier no longer wraps them with a trailing
comma that eslint then rejects. The repo's .prettierrc
(trailingComma: "all") conflicts with .eslintrc (comma-dangle
functions: "never"), and these were the spots prettier wanted to
rewrite around the edited region. Behavior is unchanged.1 parent 4c9e73c commit 3a3af7c
3 files changed
Lines changed: 71 additions & 14 deletions
File tree
- lib/doc
- spec/integration/issues
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
31 | 41 | | |
32 | 42 | | |
33 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
| 61 | + | |
60 | 62 | | |
61 | | - | |
62 | | - | |
63 | | - | |
| 63 | + | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
| 71 | + | |
70 | 72 | | |
71 | | - | |
72 | | - | |
73 | | - | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
89 | 88 | | |
90 | 89 | | |
91 | 90 | | |
| |||
112 | 111 | | |
113 | 112 | | |
114 | 113 | | |
115 | | - | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
116 | 117 | | |
117 | 118 | | |
118 | 119 | | |
| |||
Lines changed: 46 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
0 commit comments