chore(deps): update package-lock to v3#1926
Closed
panther7 wants to merge 2 commits into
Closed
Conversation
panther7
force-pushed
the
update-package-lock
branch
from
72e8f45 to
12a35fd
Compare
Contributor
Author
|
I run |
Contributor
Author
|
I found issue, this change need minimum NodeJS 16. Maybe si time, move protobuf to latest LTS (NodeJS 18). |
Contributor
Author
|
Added new commit, drops NodeJS 12 and 14 |
Contributor
Author
|
@dcodeIO Still actual. |
Member
|
For the Node 12 support floor this needs to be package lock version 2. |
Contributor
Author
|
Maybe is time drop 4 year old unsupported NodeJs a update protobufjs to v9 with support only latest NodeJs LTS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maybe, need update minimum nodejs version (v12) is to much old.