fix: RangeError [ERR_BUFFER_OUT_OF_BOUNDS] "length" is outside of buffer bounds#2026
Closed
waitingsong wants to merge 1 commit into
Closed
fix: RangeError [ERR_BUFFER_OUT_OF_BOUNDS] "length" is outside of buffer bounds#2026waitingsong wants to merge 1 commit into
waitingsong wants to merge 1 commit into
Conversation
Author
|
|
waitingsong
force-pushed
the
write-string-buffer
branch
2 times, most recently
from
e3ad74e to
94be511
Compare
…fer bounds since nodejs 22.7 call buf.utf8Write() conditionally, it will be called in buf.write() ref: protobufjs#2025
waitingsong
force-pushed
the
write-string-buffer
branch
from
94be511 to
0e834b5
Compare
basti1302
added a commit
to dash0hq/opentelemetry-js-distribution
that referenced
this pull request
Aug 28, 2024
Needs to be pinned until nodejs/node#54518 is resolved. Other references: * protobufjs/protobuf.js#2025 * protobufjs/protobuf.js#2026
basti1302
added a commit
to dash0hq/opentelemetry-js-distribution
that referenced
this pull request
Aug 28, 2024
Needs to be pinned until nodejs/node#54518 is resolved. Other references: * protobufjs/protobuf.js#2025 * protobufjs/protobuf.js#2026
|
What is preventing this from getting merged? This bug prevents using the library on Node.js 24.x.x |
Member
|
Does not reproduce for me on Node.js 24.x. As far as I can tell, this was a Node.js Buffer regression rather than a protobuf.js bug, and it appears to have been fixed upstream in nodejs/node#54524. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: RangeError [ERR_BUFFER_OUT_OF_BOUNDS] "length" is outside of buffer bounds since nodejs 22.7
call buf.utf8Write() conditionally, it will be called in buf.write()
ref: #2025