Use restore-only ccache on pull_request_target#68
Closed
poofeth wants to merge 1 commit into
Closed
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Closing this PR so I can resubmit the same fix from the CLA-covered GitHub account associated with tjbarton3@gmail.com. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the ccache setup action to use
actions/cache/restoreforpull_request_targetruns.pull_request_targetjobs can run code from a fork after maintainer approval. In that context, the job should be able to restore existing ccache state, but it should not save new.ccachecontents back into a cache namespace later consumed by trusted branch runs.This matches the restore-only pattern already used by
composer-setupandinternal/ccache-setup-windows.Validation:
ccache/action.ymlas YAML.actions/cachewhengithub.event_name != 'pull_request_target'.pull_request_targetpath now usesactions/cache/restorewith the same path, key, and restore keys.