Harden PHP repeated field indexing and namespace option validation#27852
Open
Abhinav-143x wants to merge 1 commit into
Open
Harden PHP repeated field indexing and namespace option validation#27852Abhinav-143x wants to merge 1 commit into
Abhinav-143x wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds defensive validation to two PHP code paths where malformed input can otherwise reach native runtime or generated-code boundaries.
First, the native PHP
RepeatedField::offsetSet()path now explicitly rejects negative and out-of-range indexes before converting the assigned value and before casting the index forupb_Array_Set(). This makesoffsetSet()consistent with the otherArrayAccessmethods and prevents invalid user-provided indexes from reaching the native repeated-field setter path.Second, the PHP generator now validates
php_namespaceandphp_metadata_namespacebefore using those options to derive PHP namespaces and generated filenames. This prevents malformed schema options from being emitted into generated PHP namespace/file output. Existing valid forms remain accepted, including empty options, normal namespace segments such asPhp\\Test, and the existingphp_metadata_namespace = "\\"root metadata special case.Tests run:
bazel test //src/google/protobuf/compiler/php:generator_unittestbazel build //php:extensionbazel test //php:conformance_test_cbazel test //php:conformance_testbazel test //php:proto_staleness_testbazel test //php:test_amalgamation_staleness