Skip to content

Fix stack overflow on very deep public dependency chains. #28784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 24, 2026
+18 −8
Merged

Fix stack overflow on very deep public dependency chains. #28784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions src/google/protobuf/descriptor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4449,20 +4449,30 @@ bool internal::DescriptorBuilder::IsInPackage(const FileDescriptor* file,
file->package()[package_name.size()] == '.');
}

static void RecordAllPublicDepsInto(
const FileDescriptor* file,
absl::flat_hash_set<const FileDescriptor*>& out) {
std::vector<const FileDescriptor*> queue = {file};
while (!queue.empty()) {
file = queue.back();
queue.pop_back();

if (file == nullptr || !out.insert(file).second) continue;

for (int i = 0; i < file->public_dependency_count(); i++) {
queue.push_back(file->public_dependency(i));
}
}
}

void internal::DescriptorBuilder::RecordPublicDependencies(
const FileDescriptor* file) {
if (file == nullptr || !dependencies_.insert(file).second) return;
for (int i = 0; file != nullptr && i < file->public_dependency_count(); i++) {
RecordPublicDependencies(file->public_dependency(i));
}
RecordAllPublicDepsInto(file, dependencies_);
}

void internal::DescriptorBuilder::RecordPublicOptionDependencies(
const FileDescriptor* file) {
if (file == nullptr || !option_dependencies_.insert(file).second) return;
for (int i = 0; i < file->public_dependency_count(); i++) {
RecordPublicOptionDependencies(file->public_dependency(i));
}
RecordAllPublicDepsInto(file, option_dependencies_);
}

Symbol internal::DescriptorBuilder::FindSymbolNotEnforcingDepsHelper(
Expand Down
Loading