Add optional rich presence launch announcements#1736
Open
brkzlr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
Closes #1690
When OPL starts a game, it can send a small UDP broadcast packet with the game title ID. A listener on the same local network can pick that up and set Discord rich presence without needing SMB polling or any PC IP setting in OPL.
The matching listener is here for now:
https://github.com/brkzlr/PS2RichPresence
I've also tried to add a UI option to toggle this on/off but seems that we don't have scrolling support in OPL setting menus (from what I tried at least) so adding the option causes the bottom PS buttons + "Ok" to go out of visible area on some resolutions.
I'm all ears for ideas that I might've missed for the UI setting or if the only correct option is to implement scrolling, but right now the option is only exposed through the config file.
A note about the protocol
Ideally the protocol header and specification would be upstreamed into a broader ps2homebrew repo so that all homebrew tools can reference and include it after, ensuring consistency with all tools that want to deal with rich presence info.
I'm not sure where to start the discussion for this or how, so for now I'm referencing it from my repo. Once the protocol is upstreamed, I'd follow this up with a PR that includes the header directly instead of mirroring my repo's implementation.