Install tox and flake8 dependency to run make test and make flake8#6995
Closed
abhi-jha wants to merge 2 commits into
Closed
Install tox and flake8 dependency to run make test and make flake8#6995abhi-jha wants to merge 2 commits into
abhi-jha wants to merge 2 commits into
Conversation
abhi-jha
changed the title
abhi-jha
changed the title
Member
|
Hi @abhi-jha, we don't use that portion of the Makefile anymore, everything has been moved to pre-commit. We can delete that section, but I don't think we'll add flake8 to the dependencies. You can run linting with |
Contributor
Author
|
Do you mean the Makefile is not relevant? Should I clean it up? Or do you mean just the specific sections of flake8 and tox? |
Member
|
The Makefile is relevant, the |
Contributor
Author
|
Looks like I can't reopen this MR. Raised another one : #6996 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see that setting up this project as per the Makefile needs
toxto runmake testandflake8to runmake flake8. I do not see these mentioned anywhere in the project installation steps that people need to install the pip package first before running the commands. This MR adds thetoxandflake8dependency to dev requirements.