Skip to content

Make the SSL version more human-readable#7007

Open
mengxunQAQ wants to merge 5 commits into
psf:mainfrom
mengxunQAQ:dev
Open

Make the SSL version more human-readable#7007
mengxunQAQ wants to merge 5 commits into
psf:mainfrom
mengxunQAQ:dev

Conversation

@mengxunQAQ
Copy link
Copy Markdown

When executing python -m requests.help, the previous format looked like:

{
  "chardet": {
    "version": null
  },
  "charset_normalizer": {
    "version": "2.0.12"
  },
  "cryptography": {
    "version": "40.0.2"
  },
  "idna": {
    "version": "3.7"
  },
  "implementation": {
    "name": "CPython",
    "version": "3.6.8"
  },
  "platform": {
    "release": "3.10.0-1160.119.1.el7.x86_64",
    "system": "Linux"
  },
  "pyOpenSSL": {
    "openssl_version": "30100000",
    "version": "23.2.0"
  },
  "requests": {
    "version": "2.27.1"
  },
  "system_ssl": {
    "version": "100020bf"
  },
  "urllib3": {
    "version": "1.26.19"
  },
  "using_charset_normalizer": true,
  "using_pyopenssl": true
}

The current format looks like:

{
  "chardet": {
    "version": null
  },
  "charset_normalizer": {
    "version": "2.0.12"
  },
  "cryptography": {
    "version": "40.0.2"
  },
  "idna": {
    "version": "3.7"
  },
  "implementation": {
    "name": "CPython",
    "version": "3.6.8"
  },
  "platform": {
    "release": "3.10.0-1160.119.1.el7.x86_64",
    "system": "Linux"
  },
  "pyOpenSSL": {
    "openssl_version": "OpenSSL 3.1.0 14 Mar 2023", 
    "version": "23.2.0"
  },
  "requests": {
    "version": "2.27.1"
  },
  "system_ssl": {
    "version": "OpenSSL 1.0.2k-fips  26 Jan 2017" 
  },
  "urllib3": {
    "version": "1.26.19"
  },
  "using_charset_normalizer": true,
  "using_pyopenssl": true
}

@sigmavirus24
Copy link
Copy Markdown
Contributor

I'm not opposed to adding a human readable representation but the existing representation should be reserved with a new key added for the human readable representation

Comment thread src/requests/help.py Outdated
Comment thread src/requests/help.py Outdated
@mengxunQAQ
Copy link
Copy Markdown
Author

I'm not opposed to adding a human readable representation but the existing representation should be reserved with a new key added for the human readable representation

You're right — backward compatibility should be considered. The changes have been resubmitted.

@mengxunQAQ mengxunQAQ requested a review from sigmavirus24 August 6, 2025 13:11
mengxunQAQ and others added 4 commits August 13, 2025 20:29
Co-authored-by: Ian Stapleton Cordasco <graffatcolmingov@gmail.com>
Co-authored-by: Ian Stapleton Cordasco <graffatcolmingov@gmail.com>
@mengxunQAQ
Copy link
Copy Markdown
Author

@sigmavirus24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants