fix: raise FileNotFoundError for missing TLS material (fixes #7564)#7580
Closed
muhamedfazalps wants to merge 1 commit into
Closed
fix: raise FileNotFoundError for missing TLS material (fixes #7564)#7580muhamedfazalps wants to merge 1 commit into
muhamedfazalps wants to merge 1 commit into
Conversation
When a TLS certificate or key file is not found, the code currently raises a generic OSError. This changes it to raise FileNotFoundError with the proper errno (ENOENT) and filename attribute, which is more specific and allows callers to catch this specific case. FileNotFoundError is a subclass of OSError, so this is backward compatible with existing code that catches OSError.
muhamedfazalps
force-pushed
the
fix/file-not-found-for-missing-tls
branch
from
89ccbe6 to
dc81306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7564
When a TLS certificate or key file is not found, the code currently raises a generic
OSError. This changes it to raiseFileNotFoundErrorwith the proper errno (ENOENT) and filename attribute, which is more specific and allows callers to catch this specific case.FileNotFoundErroris a subclass ofOSError, so this is backward compatible with existing code that catchesOSError.