Skip to content

Commit 5d91da2

Browse files
Dev-iLclaude
andcommitted
Remove test_aboba: duplicate of test_deserialization_simple_into_python
test_aboba exercised ("INT2", 2, 2) — a plain int round-tripping through an INT2 column. That case is already covered twice in the parametrized test_deserialization_simple_into_python: ("INT2", SmallInt(12), 12) and ("INT2", 12, 12). Adding a third plain-int/INT2 variant adds no new behaviour under test. Beyond redundancy, test_aboba had a latent hazard: it used the hard-coded table name "for_test" instead of the UUID-suffixed name the parametrized test generates, making it unsafe to run in parallel with several other tests in this file that share that same name. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent ebce7f2 commit 5d91da2

1 file changed

Lines changed: 0 additions & 28 deletions

File tree

python/tests/test_value_converter.py

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -302,34 +302,6 @@ async def test_deserialization_simple_into_python(
302302
await connection.execute(f"DROP TABLE IF EXISTS {table_name}")
303303

304304

305-
async def test_aboba(
306-
psql_pool: ConnectionPool,
307-
postgres_type: str = "INT2",
308-
py_value: Any = 2,
309-
expected_deserialized: Any = 2,
310-
) -> None:
311-
"""Test how types can cast from Python and to Python."""
312-
connection = await psql_pool.connection()
313-
await connection.execute("DROP TABLE IF EXISTS for_test")
314-
create_table_query = f"""
315-
CREATE TABLE for_test (test_field {postgres_type})
316-
"""
317-
insert_data_query = """
318-
INSERT INTO for_test VALUES ($1)
319-
"""
320-
await connection.execute(querystring=create_table_query)
321-
await connection.execute(
322-
querystring=insert_data_query,
323-
parameters=[py_value],
324-
)
325-
326-
raw_result = await connection.execute(
327-
querystring="SELECT test_field FROM for_test",
328-
)
329-
330-
assert raw_result.result()[0]["test_field"] == expected_deserialized
331-
332-
333305
async def test_deserialization_composite_into_python(
334306
psql_pool: ConnectionPool,
335307
) -> None:

0 commit comments

Comments
 (0)