Activate the distance tool to report permanently its distance.#39
Draft
valentinptc wants to merge 2 commits into
Draft
Activate the distance tool to report permanently its distance.#39valentinptc wants to merge 2 commits into
valentinptc wants to merge 2 commits into
Conversation
benptc
approved these changes
Jun 16, 2020
benptc
left a comment
benptc
left a comment
Contributor
There was a problem hiding this comment.
I like the idea but it wasn't fully working when I tested your change, so I pushed another commit that fixes the bug. Now, tapping on the tool once sets the distance considered "1", and as you move closer it goes down to 0 (similar to setting the visibility distance of something).
Contributor
|
I like how this no longer requires you to press down on the tool. I agree this makes it much more useful. |
benptc
marked this pull request as draft
June 22, 2020 15:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make the distance slider useful. Before it only worked when you touch it.
We could lower down the frequency for calculations to 10 fps in case this takes too much resources.
However its also only running while the tool is visible and loaded. So overall maybe not a big deal.