Auto-insert with single suggestion now only works when triggered manually

Author: goossens

TextEditor.cpp

@@ -4513,6 +4513,7 @@ void TextEditor::Autocomplete::setConfig(const AutoCompleteConfig* config) {
 
 bool TextEditor::Autocomplete::startTyping(Cursors& cursors) {
 	if (!active && !requestActivation && configured && configuration.triggerOnTyping) {
+		triggeredManually = false;
 		start(cursors);
 		return true;
 
@@ -4528,6 +4529,7 @@ bool TextEditor::Autocomplete::startTyping(Cursors& cursors) {
 
 bool TextEditor::Autocomplete::startShortcut(Cursors& cursors) {
 	if (!active && !requestActivation && configured && configuration.triggerOnShortcut) {
+		triggeredManually = true;
 		start(cursors);
 		return true;
 
@@ -4729,7 +4731,7 @@ bool TextEditor::Autocomplete::render(Document& document, Cursors& cursors, cons
 					requestDeactivation = true;
 					result = true;
 
-				} else if (configuration.autoInsertSingleSuggestions && state.suggestions.size() == 1) {
+				} else if (configuration.autoInsertSingleSuggestions && triggeredManually && state.suggestions.size() == 1) {
 					requestDeactivation = true;
 					result = true;
 				}

TextEditor.h

@@ -495,6 +495,7 @@ class TextEditor {
 #endif
 
 		// see if single suggestions are automatically inserted
+		// this only works when triggered manually
 		bool autoInsertSingleSuggestions = false;
 
 		// delay in milliseconds between autocomplete trigger and suggestions popup
@@ -1116,6 +1117,7 @@ class TextEditor {
 		std::chrono::system_clock::time_point activationTime;
 		AutoCompleteConfig configuration;
 		AutoCompleteState state;
+		bool triggeredManually = false;
 		size_t currentSelection = 0;
 		static constexpr float suggestionWidth = 250.0f;
 

docs/autocomplete.md

@@ -48,6 +48,7 @@ public:
 #endif
 
 	// see if single suggestions are automatically inserted
+	// this only works when triggered manually
 	bool autoInsertSingleSuggestions = false;
 
 	// delay in milliseconds between autocomplete trigger and suggestions popup