[KDE_PLUGIN] Added KDE 5 support (#3987)

Author: ksco

CMakeLists.txt

@@ -49,7 +49,7 @@ option(BOX32_BINFMT "Also setup binfmt integration for box32" ${BOX32_BINFMT})
 option(LARCH64_ABI_1 "Set to ON if building for Loongarch64 ABI 1.0 system" ${LARCH64_ABI_1})
 option(GDBJIT "Set to ON to enable GDB JIT support" ${GDBJIT})
 option(WOW64 "Set to ON if you want a WOW64 PE build in addition")
-option(BOX64_KDE_PROFILE_PLUGIN "Build the Dolphin/KIO Box64 profile context menu plugin when KF6 is available" OFF)
+option(BOX64_KDE_PROFILE_PLUGIN "Build the Dolphin/KIO Box64 profile properties plugin when KF5 or KF6 is available" OFF)
 
 if(TERMUX)
     set(TERMUX_PATH "/data/data/com.termux/files")
@@ -1431,42 +1431,57 @@ if(NOT _x86 AND NOT _x86_64)
        check_language(CXX)
        if(CMAKE_CXX_COMPILER)
            enable_language(CXX)
-           set(QT_DEFAULT_MAJOR_VERSION 6)
            find_package(ECM QUIET NO_MODULE)
            if(ECM_FOUND)
                list(APPEND CMAKE_MODULE_PATH ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR})
-               include(KDEInstallDirs6 OPTIONAL)
+               set(_BOX64_KDE_PROFILE_PLUGIN_KF_MAJOR "")
+
+               set(QT_DEFAULT_MAJOR_VERSION 6)
                find_package(Qt6 QUIET COMPONENTS Core Widgets)
                find_package(KF6CoreAddons QUIET)
                find_package(KF6KIO QUIET)
                if(Qt6_FOUND AND Qt6Widgets_FOUND AND KF6CoreAddons_FOUND AND KF6KIO_FOUND)
+                   include(KDEInstallDirs6)
+                   set(_BOX64_KDE_PROFILE_PLUGIN_KF_MAJOR 6)
+                   set(_BOX64_KDE_PROFILE_PLUGIN_QT_WIDGETS_TARGET Qt6::Widgets)
+                   set(_BOX64_KDE_PROFILE_PLUGIN_KIO_WIDGETS_TARGET KF6::KIOWidgets)
+                   set(_BOX64_KDE_PROFILE_PLUGIN_INSTALL_NAMESPACE "kf6/propertiesdialog")
+               else()
+                   set(QT_DEFAULT_MAJOR_VERSION 5)
+                   find_package(Qt5 QUIET COMPONENTS Core Widgets)
+                   find_package(KF5CoreAddons QUIET)
+                   find_package(KF5KIO QUIET)
+                   if(Qt5_FOUND AND Qt5Widgets_FOUND AND KF5CoreAddons_FOUND AND KF5KIO_FOUND)
+                       include(KDEInstallDirs5)
+                       set(_BOX64_KDE_PROFILE_PLUGIN_KF_MAJOR 5)
+                       set(_BOX64_KDE_PROFILE_PLUGIN_QT_WIDGETS_TARGET Qt5::Widgets)
+                       set(_BOX64_KDE_PROFILE_PLUGIN_KIO_WIDGETS_TARGET KF5::KIOWidgets)
+                       set(_BOX64_KDE_PROFILE_PLUGIN_INSTALL_NAMESPACE "kf5/propertiesdialog")
+                   endif()
+               endif()
+
+               if(_BOX64_KDE_PROFILE_PLUGIN_KF_MAJOR)
                    if(NOT CMAKE_LIBRARY_OUTPUT_DIRECTORY)
                        set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
                    endif()
-                   if(DEFINED QT6_INSTALL_PREFIX AND DEFINED QT6_INSTALL_PLUGINS
-                           AND NOT QT6_INSTALL_PREFIX STREQUAL "" AND NOT QT6_INSTALL_PLUGINS STREQUAL "")
-                       set(KDE_INSTALL_PLUGINDIR "${QT6_INSTALL_PREFIX}/${QT6_INSTALL_PLUGINS}")
-                   elseif(DEFINED QT6_INSTALL_PLUGINS AND NOT QT6_INSTALL_PLUGINS STREQUAL "")
-                       set(KDE_INSTALL_PLUGINDIR "${QT6_INSTALL_PLUGINS}")
-                   elseif(NOT DEFINED KDE_INSTALL_PLUGINDIR OR KDE_INSTALL_PLUGINDIR STREQUAL "")
-                       set(KDE_INSTALL_PLUGINDIR "lib/qt6/plugins")
-                   endif()
                    set(_BOX64_BUILD_SHARED_LIBS ${BUILD_SHARED_LIBS})
                    set(BUILD_SHARED_LIBS ON)
                    kcoreaddons_add_plugin(box64_profile_propertiesplugin
                        SOURCES ${CMAKE_SOURCE_DIR}/system/kde/box64_profile_propertiesplugin.cpp
-                       INSTALL_NAMESPACE "kf6/propertiesdialog")
+                       INSTALL_NAMESPACE "${_BOX64_KDE_PROFILE_PLUGIN_INSTALL_NAMESPACE}")
                    set(BUILD_SHARED_LIBS ${_BOX64_BUILD_SHARED_LIBS})
-                   target_link_libraries(box64_profile_propertiesplugin PRIVATE KF6::KIOWidgets Qt6::Widgets)
+                   target_link_libraries(box64_profile_propertiesplugin PRIVATE
+                       ${_BOX64_KDE_PROFILE_PLUGIN_KIO_WIDGETS_TARGET}
+                       ${_BOX64_KDE_PROFILE_PLUGIN_QT_WIDGETS_TARGET})
                    set_target_properties(box64_profile_propertiesplugin PROPERTIES
                        AUTOMOC ON
                        PREFIX ""
                        CXX_STANDARD 17
                        CXX_STANDARD_REQUIRED ON
                        CXX_EXTENSIONS OFF)
-                   message(STATUS "Building Box64 profile properties dialog plugin")
+                   message(STATUS "Building Box64 profile properties dialog plugin for KF${_BOX64_KDE_PROFILE_PLUGIN_KF_MAJOR}")
                else()
-                   message(STATUS "Dolphin/KIO Box64 profile plugin disabled: missing Qt6/KF6 KIO development packages")
+                   message(STATUS "Dolphin/KIO Box64 profile plugin disabled: missing Qt5/KF5 or Qt6/KF6 KIO development packages")
                endif()
            else()
                message(STATUS "Dolphin/KIO Box64 profile plugin disabled: ECM not found")

system/kde/box64_profile_propertiesplugin.cpp

@@ -2,6 +2,8 @@
 
 #include <KPluginFactory>
 
+#include <kio_version.h>
+
 #include <QByteArray>
 #include <QComboBox>
 #include <QFile>
@@ -18,6 +20,7 @@
 #include <QStandardPaths>
 #include <QString>
 #include <QUrl>
+#include <QVariantList>
 #include <QVBoxLayout>
 #include <QWidget>
 
@@ -247,7 +250,11 @@ class Box64ProfilePropertiesPlugin : public KPropertiesDialogPlugin {
 
 public:
     explicit Box64ProfilePropertiesPlugin(QObject *parent = nullptr)
+#if KIO_VERSION_MAJOR < 6
+        : KPropertiesDialogPlugin(qobject_cast<KPropertiesDialog *>(parent))
+#else
         : KPropertiesDialogPlugin(parent)
+#endif
         , m_command(configuratorCommand())
     {
         const KFileItemList items = properties->items();
@@ -332,6 +339,11 @@ class Box64ProfilePropertiesPlugin : public KPropertiesDialogPlugin {
         properties->addPage(page, localizedText("Box64", "Box64"));
     }
 
+    Box64ProfilePropertiesPlugin(QObject *parent, const QVariantList &)
+        : Box64ProfilePropertiesPlugin(parent)
+    {
+    }
+
     void applyChanges() override
     {
         if (m_path.isEmpty()) {