[RV64_DYNAREC] Fixed GETEW delta parameter for ROL/ROR/RCL/RCR#3992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Incorrect address calculation for some rotate instructions with RIP-relative memory operands on RV64 dynarec.
Reason: The GETEW macro's delta parameter was incorrectly set to 1 instead of 0 for five 16-bit rotate opcodes in the 0xD1 and 0xD3 groups (ROR Ew,1; ROL Ew,CL; ROR Ew,CL; RCL Ew,CL; RCR Ew,CL). These instructions have no immediate operand, so delta must be 0. The wrong delta caused geted() to compute an off-by-one xRIP value, leading to incorrect effective addresses for RIP-relative memory operands.
Fix: Changed GETEW(x1, 1) → GETEW(x1, 0) for the five affected cases in dynarec_rv64_66.c.
Validation: