Skip to content

Commit 4f6565b

Browse files
committed
fix(TextInput): disable "dataDetectorTypes" prop
1 parent 2bbab41 commit 4f6565b

3 files changed

Lines changed: 15 additions & 14 deletions

File tree

Libraries/Components/TextInput/TextInput.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -520,10 +520,11 @@ const TextInput = createReactClass({
520520
*
521521
* @platform ios
522522
*/
523-
dataDetectorTypes: PropTypes.oneOfType([
524-
PropTypes.oneOf(DataDetectorTypes),
525-
PropTypes.arrayOf(PropTypes.oneOf(DataDetectorTypes)),
526-
]),
523+
// dataDetectorTypes: PropTypes.oneOfType([
524+
// PropTypes.oneOf(DataDetectorTypes),
525+
// PropTypes.arrayOf(PropTypes.oneOf(DataDetectorTypes)),
526+
// ]),
527+
527528
/**
528529
* If `true`, caret is hidden. The default value is `false`.
529530
*/

Libraries/Text/TextInputLegacy/RCTTextViewManager.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ - (NSView *)view
7171
}
7272
RCT_EXPORT_VIEW_PROPERTY(mostRecentEventCount, NSInteger)
7373

74-
#if !TARGET_OS_TV
75-
RCT_REMAP_VIEW_PROPERTY(dataDetectorTypes, textView.dataDetectorTypes, UIDataDetectorTypes)
76-
#endif
74+
// #if !TARGET_OS_TV
75+
// RCT_REMAP_VIEW_PROPERTY(dataDetectorTypes, textView.dataDetectorTypes, UIDataDetectorTypes)
76+
// #endif
7777

7878
- (RCTViewManagerUIBlock)uiBlockToAmendWithShadowView:(RCTTextShadowView *)shadowView
7979
{

RNTester/js/TextInputExample.macos.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -752,13 +752,13 @@ exports.examples = [
752752
multiline={true}
753753
style={styles.multiline}
754754
/>
755-
<TextInput
756-
defaultValue="uneditable multiline text input with phone number detection: 88888888."
757-
editable={false}
758-
multiline={true}
759-
style={styles.multiline}
760-
dataDetectorTypes="phoneNumber"
761-
/>
755+
{/* <TextInput
756+
defaultValue="uneditable multiline text input with phone number detection: 88888888."
757+
editable={false}
758+
multiline={true}
759+
style={styles.multiline}
760+
dataDetectorTypes="phoneNumber"
761+
/> */}
762762
<TextInput
763763
placeholder="multiline with children"
764764
multiline={true}

0 commit comments

Comments
 (0)