fix: <Slider> w/o "onValueChange" prop

aleclarson · aleclarson · commit b99f0812814e · 2019-01-28T19:24:43.000-05:00
diff --git a/React/Views/RCTSliderManager.m b/React/Views/RCTSliderManager.m
@@ -32,16 +32,16 @@ - (void)sliderValueChanged:(RCTSlider*)sender {
   NSEvent *event = [[NSApplication sharedApplication] currentEvent];
   BOOL endingDrag = event.type == NSLeftMouseUp;
   if (!endingDrag) {
-    sender.onValueChange(@{@"value": @(value)});
+    if (sender.onValueChange) {
+      sender.onValueChange(@{@"value": @(value)});
+    }
   } else {
     if (sender.onSlidingComplete) {
       sender.onSlidingComplete(@{@"value": @(value)});
     }
   }
 }
 
-
-
 RCT_EXPORT_VIEW_PROPERTY(value, float);
 RCT_EXPORT_VIEW_PROPERTY(step, float);
 RCT_EXPORT_VIEW_PROPERTY(trackImage, NSImage);

Original file line number	Diff line number	Diff line change
`@@ -32,16 +32,16 @@ - (void)sliderValueChanged:(RCTSlider*)sender {`
`32`	`32`	`NSEvent *event = [[NSApplication sharedApplication] currentEvent];`
`33`	`33`	`BOOL endingDrag = event.type == NSLeftMouseUp;`
`34`	`34`	`if (!endingDrag) {`
`35`		`- sender.onValueChange(@{@"value": @(value)});`
	`35`	`+ if (sender.onValueChange) {`
	`36`	`+ sender.onValueChange(@{@"value": @(value)});`
	`37`	`+ }`
`36`	`38`	`} else {`
`37`	`39`	`if (sender.onSlidingComplete) {`
`38`	`40`	`sender.onSlidingComplete(@{@"value": @(value)});`
`39`	`41`	`}`
`40`	`42`	`}`
`41`	`43`	`}`
`42`	`44`
`43`		`-`
`44`		`-`
`45`	`45`	`RCT_EXPORT_VIEW_PROPERTY(value, float);`
`46`	`46`	`RCT_EXPORT_VIEW_PROPERTY(step, float);`
`47`	`47`	`RCT_EXPORT_VIEW_PROPERTY(trackImage, NSImage);`