Skip to content

Commit fa3bb6c

Browse files
committed
fix request codes
1 parent 35370f8 commit fa3bb6c

File tree

3 files changed

+15
-19
lines changed

3 files changed

+15
-19
lines changed

app/src/main/java/com/github/developerpaul123/filepickerlibrary/app/MainActivity.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,18 +29,18 @@
2929

3030
import com.devpaul.filepicker.R;
3131
import com.devpaul.materiallibrary.views.MaterialFlatButton;
32-
import com.github.developerpaul123.filepickerlibrary.FilePicker;
3332
import com.github.developerpaul123.filepickerlibrary.FilePickerActivity;
3433
import com.github.developerpaul123.filepickerlibrary.FilePickerBuilder;
34+
import com.github.developerpaul123.filepickerlibrary.enums.FileType;
3535
import com.github.developerpaul123.filepickerlibrary.enums.Request;
3636
import com.github.developerpaul123.filepickerlibrary.enums.Scope;
37-
import com.github.developerpaul123.filepickerlibrary.enums.FileType;
3837
import com.github.developerpaul123.filepickerlibrary.enums.ThemeType;
3938

4039

4140
public class MainActivity extends AppCompatActivity {
4241

43-
private static int REQUEST_FILE = 10;
42+
static int REQUEST_FILE = 10;
43+
static int REQUEST_DIRECTORY = 11;
4444

4545
@Override
4646
protected void onCreate(Bundle savedInstanceState) {
@@ -84,11 +84,11 @@ public PlaceholderFragment() {
8484
@Override
8585
public void onActivityResult(int requestCode, int resultCode, Intent data) {
8686

87-
if (requestCode == FilePickerActivity.REQUEST_DIRECTORY && resultCode == RESULT_OK) {
87+
if (requestCode == REQUEST_DIRECTORY && resultCode == RESULT_OK) {
8888
Toast.makeText(getActivity(), "File Selected: " + data
8989
.getStringExtra(FilePickerActivity.FILE_EXTRA_DATA_PATH),
9090
Toast.LENGTH_LONG).show();
91-
} else if (requestCode == FilePickerActivity.REQUEST_FILE && resultCode == RESULT_OK) {
91+
} else if (requestCode == REQUEST_FILE && resultCode == RESULT_OK) {
9292
Toast.makeText(getActivity(), "File Selected: " + data
9393
.getStringExtra(FilePickerActivity.FILE_EXTRA_DATA_PATH),
9494
Toast.LENGTH_LONG).show();
@@ -108,9 +108,9 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
108108
public void onClick(View view) {
109109
Intent filePickerActivity = new Intent(getActivity(), FilePickerActivity.class);
110110
filePickerActivity.putExtra(FilePickerActivity.SCOPE_TYPE, Scope.ALL);
111-
filePickerActivity.putExtra(FilePickerActivity.REQUEST_CODE, FilePickerActivity.REQUEST_DIRECTORY);
111+
filePickerActivity.putExtra(FilePickerActivity.REQUEST_CODE, Request.DIRECTORY);
112112
filePickerActivity.putExtra(FilePickerActivity.INTENT_EXTRA_FAB_COLOR_ID, android.R.color.holo_green_dark);
113-
startActivityForResult(filePickerActivity, FilePickerActivity.REQUEST_DIRECTORY);
113+
startActivityForResult(filePickerActivity, REQUEST_DIRECTORY);
114114
}
115115
});
116116

library/src/main/java/com/github/developerpaul123/filepickerlibrary/FilePicker.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ public void onItemClicked(View item, int position) {
206206
/**
207207
* Request code for this activity
208208
*/
209-
private int requestCode;
209+
private Request requestCode;
210210
/**
211211
* {@code Intent} used to send back the data to the calling activity
212212
*/
@@ -285,7 +285,7 @@ public void onClick(View view) {
285285
//set default if it is null
286286
scopeType = Scope.ALL;
287287
}
288-
requestCode = givenIntent.getIntExtra(REQUEST_CODE, Request.DIRECTORY.ordinal());
288+
requestCode = (Request) givenIntent.getSerializableExtra(REQUEST_CODE);
289289

290290
colorId = givenIntent.getIntExtra(INTENT_EXTRA_COLOR_ID, android.R.color.holo_blue_light);
291291
drawableId = givenIntent.getIntExtra(INTENT_EXTRA_DRAWABLE_ID, -1);
@@ -466,7 +466,7 @@ private void initializeViews() {
466466
selectButton.setOnClickListener(new View.OnClickListener() {
467467
@Override
468468
public void onClick(View view) {
469-
if (requestCode == Request.DIRECTORY.ordinal()) {
469+
if (requestCode == Request.DIRECTORY) {
470470
if (currentFile.isDirectory()) {
471471
curDirectory = currentFile;
472472
data = new Intent();

library/src/main/java/com/github/developerpaul123/filepickerlibrary/FilePickerActivity.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,9 @@
4949
import com.afollestad.materialdialogs.MaterialDialog;
5050
import com.devpaul.materiallibrary.views.MaterialFloatingActionButton;
5151
import com.github.developerpaul123.filepickerlibrary.adapter.FileListAdapter;
52-
import com.github.developerpaul123.filepickerlibrary.enums.Scope;
5352
import com.github.developerpaul123.filepickerlibrary.enums.FileType;
53+
import com.github.developerpaul123.filepickerlibrary.enums.Request;
54+
import com.github.developerpaul123.filepickerlibrary.enums.Scope;
5455
import com.github.developerpaul123.filepickerlibrary.enums.ThemeType;
5556

5657
import java.io.File;
@@ -62,11 +63,6 @@
6263
*/
6364
public class FilePickerActivity extends ListActivity implements NameFileDialogInterface {
6465

65-
/**
66-
* Request code for when you want the file path to a directory.
67-
*/
68-
public static final int REQUEST_DIRECTORY = 101;
69-
7066
/**
7167
* Request code for when you want the file path to a specific file.
7268
*/
@@ -210,7 +206,7 @@ public class FilePickerActivity extends ListActivity implements NameFileDialogIn
210206
/**
211207
* Request code for this activity
212208
*/
213-
private int requestCode;
209+
private Request requestCode;
214210
/**
215211
* {@code Intent} used to send back the data to the calling activity
216212
*/
@@ -284,7 +280,7 @@ protected void onCreate(Bundle savedInstanceState) {
284280
//set default if it is null
285281
scopeType = Scope.ALL;
286282
}
287-
requestCode = givenIntent.getIntExtra(REQUEST_CODE, REQUEST_DIRECTORY);
283+
requestCode = (Request) givenIntent.getSerializableExtra(REQUEST_CODE);
288284

289285
colorId = givenIntent.getIntExtra(INTENT_EXTRA_COLOR_ID, android.R.color.holo_blue_light);
290286
drawableId = givenIntent.getIntExtra(INTENT_EXTRA_DRAWABLE_ID, -1);
@@ -452,7 +448,7 @@ public void onClick(View v) {
452448
selectButton.setOnClickListener(new View.OnClickListener() {
453449
@Override
454450
public void onClick(View view) {
455-
if (requestCode == REQUEST_DIRECTORY) {
451+
if (requestCode == Request.DIRECTORY) {
456452
if (currentFile.isDirectory()) {
457453
curDirectory = currentFile;
458454
data = new Intent();

0 commit comments

Comments
 (0)