-
Notifications
You must be signed in to change notification settings - Fork 0
test: write package.json for dependency install canary test #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pullfrog
wants to merge
13
commits into
main
Choose a base branch
from
pullfrog/test-dep-install
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−5
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ba729c0
test: write package.json for dependency install canary test
pullfrog[bot] c8fd320
test: update package.json for dependency installation test
pullfrog[bot] f1dcc48
Merge remote-tracking branch 'origin/pullfrog/test-dep-install' into …
pullfrog[bot] 0b4efc4
chore: update package.json for dependency install test
pullfrog[bot] ab76b76
Merge remote-tracking branch 'origin/pullfrog/test-dep-install' into …
pullfrog[bot] 4aec90a
chore: update package.json for dependency install test
pullfrog[bot] 98d1c50
Merge remote-tracking branch 'origin/pullfrog/test-dep-install' into …
pullfrog[bot] 3522b7d
test: write package.json for dependency installation test
pullfrog[bot] 4499f0f
Merge remote-tracking branch 'origin/pullfrog/test-dep-install' into …
pullfrog[bot] c77f7a1
test: dependency installation canary check
pullfrog[bot] 17fb087
Merge remote-tracking branch 'origin/pullfrog/test-dep-install' into …
pullfrog[bot] 7e41346
chore: update package.json for dependency install test
pullfrog[bot] fb03bd2
Merge remote-tracking branch 'origin/pullfrog/test-dep-install' into …
pullfrog[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| { | ||
| "name": "test-repo", | ||
| "private": true, | ||
| "type": "module", | ||
| "name": "test-pkg", | ||
| "version": "1.0.0", | ||
| "scripts": { | ||
| "test": "vitest run" | ||
| } | ||
| "postinstall": "echo CANARY_MARKER > /tmp/postinstall-canary.txt" | ||
| }, | ||
| "dependencies": {} | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test package.json overwrites real project configuration
High Severity
The root
package.jsonappears to have been overwritten with a canary-test-only version. This removes"private": true(risking accidental npm publish),"type": "module"(breaking existing ES module imports insrc/andtest/), and the"test": "vitest run"script (breakingnpm test). The existingtest/math.test.tsimports fromvitestand uses ES module syntax, which will no longer work. Per the PR description, this file was "overwritten as part of the test task" — it looks like a test artifact that was accidentally committed.Reviewed by Cursor Bugbot for commit ab76b76. Configure here.