[NFC] Allow stalled frontend request assertions to be flushed#35
Open
Scheremo wants to merge 1 commit into
Open
[NFC] Allow stalled frontend request assertions to be flushed#35Scheremo wants to merge 1 commit into
Scheremo wants to merge 1 commit into
Conversation
Scheremo
force-pushed
the
pr-assertion-refinement
branch
from
April 17, 2026 06:54
3c32dc6 to
c353cb6
Compare
Scheremo
marked this pull request as draft
April 17, 2026 07:21
Scheremo
force-pushed
the
pr-assertion-refinement
branch
from
April 17, 2026 08:54
c353cb6 to
fd6d2eb
Compare
Scheremo
changed the title
Scheremo
marked this pull request as ready for review
April 17, 2026 08:56
Scheremo
marked this pull request as draft
April 17, 2026 11:26
Scheremo
force-pushed
the
pr-assertion-refinement
branch
2 times, most recently
from
April 17, 2026 11:55
a539c91 to
35df647
Compare
Scheremo
changed the title
Scheremo
force-pushed
the
pr-assertion-refinement
branch
from
April 17, 2026 11:56
35df647 to
53f4746
Compare
Scheremo
marked this pull request as ready for review
April 17, 2026 13:18
colluca
requested changes
Jul 14, 2026
Collaborator
There was a problem hiding this comment.
Looks good to me, but could you align the assertions with the common_cells macros used elsewhere, and better even the stability-checking assertions?
`ASSERT_STABLE(InstReqStable, in_valid_i, in_ready_o, in_valid_i, '0, clk_i, !rst_ni || flush_valid_i)
`ASSERT_STABLE(InstReqDataStable, in_valid_i, in_ready_o, in_addr_i, '0, clk_i, !rst_ni || flush_valid_i)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.