Skip to content

Commit 6d03c4e

Browse files
dklibanclaude
andauthored
fix: skip feature service tests and require all tests to pass (#1160)
The two feature service tests require a Red Hat mTLS certificate and access to feature.stage.api.redhat.com, which are only available in the ephemeral CI environment. Skip them in pulp-test. Also: the agent must now treat ANY test failure as a workflow failure. No proceeding to commit with failing tests. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 32f9f44 commit 6d03c4e

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

.alcove/agents/upgrade-deps/AGENT.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,9 @@ This runs:
268268
5. pulp_npm tests (test_pull_through_install)
269269
6. pulp_service functional tests
270270

271-
If tests fail:
271+
Note: two feature service tests (`test_forbidden_feature_service`, `test_entitled_feature_service`) are excluded because they require a Red Hat mTLS certificate and access to `feature.stage.api.redhat.com`, which are not available in the dev container.
272+
273+
ALL tests MUST pass. If any test fails, the workflow is NOT complete. Do NOT proceed to Phase 7 with failing tests. Instead:
272274
- Analyze the failure to determine if it's caused by a patch, by `pulp_service/` code, or by an upstream API change
273275
- Fix the patch or code accordingly (edit files on /workspace — they're shared)
274276
- Restart services if needed and re-run the failing tests with `pulp-test --pyargs {test_spec}`

dev-container/scripts/pulp-test

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,10 @@ run_tests() {
121121

122122
echo "--- Test 6/6: pulp_service functional ---"
123123
pytest -v -r sx --color=yes --pyargs pulp_service.tests.functional \
124-
-m 'not parallel' || FAILED=$((FAILED + 1))
124+
-m 'not parallel' \
125+
--deselect pulp_service/tests/functional/test_feature_service.py::test_forbidden_feature_service \
126+
--deselect pulp_service/tests/functional/test_feature_service.py::test_entitled_feature_service \
127+
|| FAILED=$((FAILED + 1))
125128

126129
echo "=== Results: $((6 - FAILED))/6 test suites passed ==="
127130
[ "$FAILED" -eq 0 ]

0 commit comments

Comments
 (0)