Check for file in ENABLED_PLUGINS

[mdellweg]

No description provided.

[evgeni]

It's pulp_file, no?

[mdellweg]

yes it is.

[mdellweg]

That approach didn't work for me...

[mdellweg]

And without buyin on the pulpcore side, i don't see that we can add validation for the settings.
@pedro-psb any idea on the dynaconf side of things?

[pedro-psb]

Sorry, somehow I didn't see that before.

So yeah, this should be validated in the settings, because the error is raised before those django checks.

The easiest way is adding a dynaconf hook.
It could even append "pulp_file" there if its absence, if that's not too much of a surprise.

--- /dev/null
+++ b/pulp_container/app/dynaconf_hooks.py
@@ -0,0 +1,10 @@
+# dynaconf_hooks.py
+from dynaconf import ValidationError
+
+
+def post(settings):
+    data = {"dynaconf_merge": True}
+    enabled_plugins = settings.get("ENABLED_PLUGINS")
+    if enabled_plugins and "pulp_file" not in enabled_plugins:
+        raise ValidationError("pulp_file must be enabled to use pulp_container")
+    return data

Or we could define some plugin config so plugins can declare which plugins they require, and let pulpcore validate it.

[mdellweg]

I believe this works now. Thanks @pedro-psb