Skip to content

Add pulp_labels to Namespaces#2172

Merged
gerrod3 merged 1 commit into
pulp:mainfrom
gerrod3:name-label
Mar 10, 2026
Merged

Add pulp_labels to Namespaces#2172
gerrod3 merged 1 commit into
pulp:mainfrom
gerrod3:name-label

Conversation

@gerrod3
Copy link
Copy Markdown
Contributor

@gerrod3 gerrod3 commented Jan 27, 2026

fixes: #2139
Generated by: claude-4.5-sonnet

@pichuzhkin
Copy link
Copy Markdown

@gerrod3 hello! Do you have plans to merge this PR shortly?)
Thank you so much!

@gerrod3
Copy link
Copy Markdown
Contributor Author

gerrod3 commented Mar 10, 2026

@pichuzhkin Yes, sorry this got lost in the backlog.

fixes: pulp#2139
Generated by: claude-4.5-sonnet

Fields:
name (models.TextField): The name of the namespace.
pulp_labels (HStoreField): Key-value pairs for labeling and organizing namespaces.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was on BaseModel, but apparently not. Do you remember why?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original implementation before it was a HStoreField was on BaseModel. That was removed a long time ago for performance reasons. Why we switched to just adding HStoreField to each model individually I don't remember.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the joins across master-detail were an issue

@gerrod3 gerrod3 merged commit 8eafca9 into pulp:main Mar 10, 2026
13 checks passed
@gerrod3 gerrod3 deleted the name-label branch March 10, 2026 20:44
@pichuzhkin
Copy link
Copy Markdown

@pichuzhkin Yes, sorry this got lost in the backlog.

@gerrod3 Thank you so much!
Do you plan release it soon?

@gerrod3
Copy link
Copy Markdown
Contributor Author

gerrod3 commented Mar 11, 2026

@pichuzhkin Next Tuesday hopefully. We have some other issues we need to fix first before we can do a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Container Namespaces don't have labels (pulp_labels) field and methods for managing them

3 participants