Skip to content

[PR #2219/c81d7440 backport][2.19] Fix monolithic push memory issues #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggainey merged 1 commit into from
Mar 9, 2026
Merged

[PR #2219/c81d7440 backport][2.19] Fix monolithic push memory issues #2252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/+mono-push.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed memory usage when pushing large images with monolithic upload.
15 changes: 9 additions & 6 deletions pulp_container/app/registry_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,24 +880,27 @@ def put(self, request, path, pk=None):
"""
Create a blob from uploaded chunks.

This request makes the upload complete. It can whether carry a zero-length
body or last chunk can be uploaded.
This request makes the upload complete. It can either carry a zero-length
body or contain the last chunk.

"""
_, repository = self.get_dr_push(request, path)

digest = request.query_params["digest"]
chunk = request.META["wsgi.input"]
# last chunk (and the only one) from monolitic upload
# or last chunk from chunked upload
last_chunk = ContentFile(chunk.read())
upload = get_object_or_404(models.Upload, pk=pk, repository=repository)

if artifact := upload.artifact:
if upload.size == 0:
# monolithic upload to be completed in PUT
artifact = self.create_single_chunk_artifact(chunk)
elif artifact := upload.artifact:
# chunked upload was completed in PATCH
if artifact.sha256 != digest[len("sha256:") :]:
raise Exception("The digest did not match")
artifact.touch()
else:
# chunked upload to be completed in PUT
last_chunk = ContentFile(chunk.read())
chunks = UploadChunk.objects.filter(upload=upload).order_by("offset")
with NamedTemporaryFile("ab") as temp_file:
for chunk in chunks:
Expand Down